Closed Bug 1957381 Opened 18 days ago Closed 15 days ago

[wpt-sync] Sync PR 51716 - Replace ConsumeNumberRaw with ConsumeNumber for cubic-bezier()

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
139 Branch
Tracking Flags:
Tracking Status
firefox139 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51716 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51716
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Replace ConsumeNumberRaw with ConsumeNumber for cubic-bezier()

We still don't support element-dependent arguments, but add a test and a
comment in the code.

Bug: 407420298
Change-Id: If1e802bcdc0c868ab4c7edd4231900c94f7275b5
Reviewed-on: https://chromium-review.googlesource.com/6415890
WPT-Export-Revision: b6c1748f7266dffbae9ef9bb0d525681c978c83b

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 22 subtests

Status Summary

Firefox

OK : 1
PASS: 16
FAIL: 6

Chrome

OK : 1
PASS: 19
FAIL: 3

Safari

OK : 1
PASS: 21
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /css/css-easing/timing-functions-syntax-valid.html [wpt.fyi]
    • e.style['animation-timing-function'] = "steps(calc(-10), start)" should set the property value: FAIL
    • e.style['animation-timing-function'] = "steps(calc(5 / 2), start)" should set the property value: FAIL
    • e.style['animation-timing-function'] = "steps(calc(2 + sign(100em - 1px)))" should set the property value: FAIL

New Tests That Don't Pass

  • /css/css-easing/timing-functions-syntax-valid.html [wpt.fyi]
    • e.style['animation-timing-function'] = "cubic-bezier(calc(-2), calc(0.7 / 2), calc(1.5), calc(0))" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)
    • e.style['animation-timing-function'] = "cubic-bezier(0, sibling-index(), 1, sign(2em - 20px))" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['animation-timing-function'] = "steps(calc(-10), start)" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
    • e.style['animation-timing-function'] = "steps(calc(5 / 2), start)" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
    • e.style['animation-timing-function'] = "steps(calc(1), jump-none)" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)
    • e.style['animation-timing-function'] = "steps(calc(2 + sign(100em - 1px)))" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38239bf436b3 [wpt PR 51716] - Replace ConsumeNumberRaw with ConsumeNumber for cubic-bezier(), a=testonly https://hg.mozilla.org/integration/autoland/rev/78d7c8d2cd71 [wpt PR 51716] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/38239bf436b3
https://hg.mozilla.org/mozilla-central/rev/78d7c8d2cd71

Status: NEW → RESOLVED
Closed: 15 days ago
status-firefox139: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
You need to log in before you can comment on or make changes to this bug.