1957433 - QM: Add dedicated test for temporary storage eviction using SimpleDB

Status: ASSIGNED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

The goal of this bug is to add a dedicated test for temporary storage eviction using the SimpleDB internal API. This will restore essential coverage that was lost years ago.

Historically, test_temporary_storage.js (added in bug 785884) was intended to verify core eviction behavior for temporary storage, but it was rewritten in bug 1144806 due to intermittent failures. At that time, SimpleDB/LSNG was not yet available, and the test relied on IndexedDB, which introduced unpredictable storage usage that made precise quota control difficult. As a result, some of the general eviction coverage was lost during the rewrite.

There are still a few xpcshell tests for eviction, such as:

• test_persist_eviction.js
• test_eviction.js

However, these focus on specific edge cases, such as persisted origins or client-specific behavior, and do not provide a broad, controlled view of origin eviction functionality.

This bug will introduce a new test that:

• Uses SimpleDB for deterministic writes and predictable storage usage
• Covers eviction behavior across multiple origins
• Simulates semi-realistic usage patterns in separate stages
• Verifies access time tracking, inactivity-based eviction, and quota shrinking behavior

By restoring this coverage, we can ensure that core eviction logic remains well-tested and that future changes do not unintentionally regress existing behavior.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1957433 - QM: Add pref to disable origin access time updates in temporary storage for manual testing; r=#dom-storage

Adds a new pref, dom.quotaManager.temporaryStorage.updateOriginAccessTime, to
allow disabling updates of origin access time in temporary storage.

This pref is intended for manual testing and debugging. The goal is to
temporarily disable access time tracking and confirm that our current test
suite does not fail, which highlights that we are missing test coverage for
this behavior.

The default value is true to preserve current behavior.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1957433 - QM: Adjust tests to disable quota info cache and avoid relying on origin access time updates; r=#dom-storage

Updates several tests to explicitly disable the quota info cache by setting
dom.quotaManager.loadQuotaFromCache to false.

These tests were previously relying on origin access time updates (which set
the "accessed" flag) to trigger full origin scans. This behavior was a side
effect rather than an intentional part of the test logic.

Disabling the quota info cache ensures these tests do not depend on unrelated
behavior and continue to pass even when access time updates are disabled via
the dom.quotaManager.temporaryStorage.updateOriginAccessTime pref.

This is a follow-up to the patch that added the pref for manual testing.

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1957433 - QM: Add dedicated test for temporary storage eviction using SimpleDB; r=#dom-storage

This patch adds a new test that verifies temporary storage eviction logic using
the internal SimpleDB API. This test restores essential coverage that was lost
when test_temporary_storage.js was rewritten in the past because IndexedDB
increases storage usage unpredictably, making precise eviction testing
difficult.

See the main comment in the test for details on each simulated stage and what
behavior is being verified.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df2294ed6d6f
QM: Add pref to disable origin access time updates in temporary storage for manual testing; r=dom-storage-reviewers,jstutte

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/df2294ed6d6f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/003309494284
QM: Adjust tests to disable quota info cache and avoid relying on origin access time updates; r=dom-storage-reviewers,jstutte

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/003309494284