1957507 - "Foxfooding feedback" for link previews wants better link and/or copy

Status: VERIFIED FIXED

(Core :: Machine Learning, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

STR:

1. set browser.ml.linkPreview.enabled to true
2. hold Option + Shift and move the cursor over a link
3. Press the "Foxfeeding feedback" link

Actual:

A Google Spreadsheet links open and you don't have access.

Expected:

A page opens where you can do something.

Comment 1

[Ed Lee :Mardak]

we switched the url to more generic connect site in bug 1955095 but we'll likely need to point to a specific connect post or other feedback page that probably wants some copy other than "foxfooding"

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1957507 - "Foxfooding feedback" for link previews wants better link and/or copy r=txia!

Update hardcoded link and copy

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ace26411cbb0
"Foxfooding feedback" for link previews wants better link and/or copy r=txia,firefox-ai-ml-reviewers

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ace26411cbb0

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Mardak, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: we'll want qualitative feedback of link previews via connect link

Comment 7

[Ed Lee :Mardak]

Attachment: Bug 1957507 - "Foxfooding feedback" for link previews wants better link and/or copy

Update hardcoded link and copy

Original Revision: https://phabricator.services.mozilla.com/D244074

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: "foxfooding" copy shown pointing to generic connect page
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: 1. enable/show link preview with key points 2. check feedback link with expected copy and specific connect post instead of generic
• Risk associated with taking this patch: low
• Explanation of risk level: simple url and text change. while the url is still currently hidden, it will be made public as part of nimbus labs rollout
• String changes made/needed: none exposed to localization
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/efc2501c1bbb

Comment 10

[Ciprian Georgiu, Desktop QA]

I've verified that this issue is fixed in the latest builds: Beta 138.0b4 (Treeherder build) and Nightly 139.0a1, on macOS 14, Ubuntu 20.04, and Windows 11. I confirm that clicking the "Share feedback" link on the Link Preview card correctly opens this page - https://connect.mozilla.org/t5/moderation-management-discussion/try-out-link-previews-on-firefox-labs/td-p/92012.