1957581 - wide margin of menu bar items, should be normal/compact as before and in other applications

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot: firefox menu

Firefox 139.0a1 20250331215235 on Windows 10

The menu bar items have wide margin now which is different from the OS default and other applications. This seems unintentional.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1957581 - Don't apply menuitem padding to menubar items on windows. r=#theme

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1957581 - Don't apply menuitem padding to contextmenu navigation. r=#theme

Another regression from the same bug.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1957581 - Remove support for iconic menubar items. r=#theme

We don't use it, this simplifies a bit the styling.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1957581 - Unify menu styling a bit more. r=dao,#theme

The macOS menu iconic bit doesn't seem needed? Empty icons don't take
space already anywhere.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3097a2dce507
Don't apply menuitem padding to contextmenu navigation. r=desktop-theme-reviewers,Itiel

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3097a2dce507

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/585929a618dd
Don't apply menuitem padding to menubar items on windows. r=desktop-theme-reviewers,Itiel

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/585929a618dd

Comment 9

[Phabricator Automation]

Comment on attachment 9475988 [details]
Bug 1957581 - Remove support for iconic menubar items. r=#theme

Revision D243786 was moved to bug 1958213. Setting attachment 9475988 [details] to obsolete.

Comment 10

[Phabricator Automation]

Comment on attachment 9475989 [details]
Bug 1957581 - Unify menu styling a bit more. r=dao,#theme

Revision D243787 was moved to bug 1958213. Setting attachment 9475989 [details] to obsolete.