1957639 - [wpt-sync] Sync PR 51743 - Revert "Update installOnDevice API to await successful installation"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 51743 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51743
Details from upstream follow.

[e-mail] <[e-mail]> wrote:

Revert "Update installOnDevice API to await successful installation"

This reverts commit d539ac043d1783f0c2015c17ba8654bf7360ef89.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5739263770492928

Sample build with failed test: https://ci.chromium.org/b/8718854391800400225
Affected test(s):
ninja://:chrome_wpt_tests/external/wpt/speech-api/SpeechRecognition-installOnDevice.https.html
ninja://:chrome_wpt_tests/virtual/speech-with-unified-autoplay/external/wpt/speech-api/SpeechRecognition-installOnDevice.https.html

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5739263770492928&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6399253&type=BUG

Original change's description:

Update installOnDevice API to await successful installation

This CL updates the installOnDevice API of the Web Speech API to resolve
to true when the installation of the on-device speech recognition
language pack succeeds instead of when the download starts successfully.

Bug: 40286514
Change-Id: I829d39699187875896225543919a018c83fbddb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6399253
Commit-Queue: Evan Liu \<[e-mail]>
Reviewed-by: Fr \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1440457}

Bug: 40286514
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I60956cc59bdf96d42c457e1346f8b1b3f10641b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6418574
Owners-Override: Mikihito Matsuura \<[e-mail]>
Reviewed-by: Mikihito Matsuura \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Mikihito Matsuura \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1440673}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
PASS: 2

Safari

OK : 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /speech-api/SpeechRecognition-installOnDevice.https.html [wpt.fyi]
  • SpeechRecognition.installOnDevice resolves with a boolean value.: FAIL (Chrome: PASS, Safari: FAIL)
  • SpeechRecognition.installOnDevice rejects in a detached context.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77ed2ec5a671
[wpt PR 51743] - Revert "Update installOnDevice API to await successful installation", a=testonly

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/77ed2ec5a671