1957702 - Review usages of inverted if conditions

Status: RESOLVED FIXED

(Focus :: General, task)

Description

[Mihai Adrian Carare [:mcarare]]

Reviewing other inverted if conditions to check if they make sense ( actions only on negative conditions) or they should be reverted to make the intent more clear when refactoring.

Comment 1

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1957702 - Refactor code to replace inverted ifs.

Comment 2

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1957702 - Remove unnecessary inTesting parameter

Depends on D244703

Comment 3

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1957702 - Refactor setupLocaleDescriptor and add tests.

Depends on D244704

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3258e48a392d
Refactor code to replace inverted ifs. r=android-reviewers,avirvara
https://hg.mozilla.org/integration/autoland/rev/5d6c30851c7f
Remove unnecessary inTesting parameter r=android-reviewers,avirvara
https://hg.mozilla.org/integration/autoland/rev/44b4e4f4e63f
Refactor setupLocaleDescriptor and add tests. r=android-reviewers,avirvara

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3258e48a392d
https://hg.mozilla.org/mozilla-central/rev/5d6c30851c7f
https://hg.mozilla.org/mozilla-central/rev/44b4e4f4e63f