1957720 - Intermittent comm/mail/components/inappnotifications/test/unit/test_in_app_notifications.js | test_getSeed - [test_getSeed : 251] Different ID gives a different seed - 98 != 98

Status: NEW

(Thunderbird :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=501899978&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/KzJrZ8sESWuplpzK0wzELg/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin]]

I think new in this push so from either bug 1936324 or bug 1950887

Comment 2

[Magnus Melin [:mkmelin]]

Bug 1950887 touched the file so...

Comment 3

[Intermittent Failures Robot]

1 failures were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Table

	no_variant
windows11-64-2009-qr--/debug	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1957720&startday=2025-03-31&endday=2025-04-06&tree=all

Comment 4

[Toby Pilling [:tobyp]]

Martin, won't we get a matching seed 1/100 times?

https://searchfox.org/comm-central/source/mail/components/inappnotifications/test/unit/test_in_app_notifications.js#240-244

Comment 5

[Martin Giger [:freaktechnik]]

Indeed, assuming the distribution is actually even (which it probably isn't quite). I've thought about this a few times, and the only way I can think of to make this fail less would be to instead assert that we get at least two different seeds when we try a couple of times like at the end of that task. But in theory there's always a case where we only ever get one seed, such is randomness. But I think having an occasional failure is better than a test that accepts the XKCD standard random implementation.