1957729 - Show data collection permissions in the update prompt

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[William Durand [:willdurand]]

Kinda like Bug 1955942 but specific to add-on updates. We'll want to automatically apply the update when the "none" data type is specified in an update.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1957729 - Show data collection permissions in the update prompt. r?rpl!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d28c0076078
Show data collection permissions in the update prompt.  r=rpl,fluent-reviewers,bolsson

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_webextension_install.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/fe59e1658be03e94f8e8210225dbb0303eb2472f

Push with failures

Failure log ->TEST-UNEXPECTED-FAIL | xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_normalized_optional_origins - [test_normalized_optional_origins : 655] optionalPermissions are correct

TEST-PASS | xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_permissions_prompt - [test_permissions_prompt : 608] Extension was installed - {} != null
[task 2025-04-12T12:08:32.747Z] 12:08:32     INFO -  "CONSOLE_MESSAGE: (info) 1744459712636	addons.xpi	DEBUG	removeTemporaryFile: file:///var/folders/6g/n83qhpfd3nl1tkncq9dmn5mm000014/T/xpc-profile-9y36e6pr/temp/generated-extension-7.xpi does not own temp file"
[task 2025-04-12T12:08:32.747Z] 12:08:32     INFO -  "CONSOLE_MESSAGE: (info) 1744459712637	addons.xpi	DEBUG	Calling bootstrap method shutdown on {5d49fde5-fd9a-4584-8bf1-9c20268be5e2} version 1.0"
[task 2025-04-12T12:08:32.747Z] 12:08:32     INFO -  "CONSOLE_MESSAGE: (info) 1744459712638	addons.xpi	DEBUG	Calling bootstrap method uninstall on {5d49fde5-fd9a-4584-8bf1-9c20268be5e2} version 1.0"
[task 2025-04-12T12:08:32.747Z] 12:08:32     INFO -  "CONSOLE_MESSAGE: (info) 1744459712639	addons.xpi	DEBUG	Disabling XPIState for {5d49fde5-fd9a-4584-8bf1-9c20268be5e2}"
[task 2025-04-12T12:08:32.748Z] 12:08:32     INFO -  "CONSOLE_MESSAGE: (info) 1744459712639	addons.xpi	DEBUG	uninstallAddon: flushing jar cache /var/folders/6g/n83qhpfd3nl1tkncq9dmn5mm000014/T/xpc-profile-9y36e6pr/extensions/{5d49fde5-fd9a-4584-8bf1-9c20268be5e2}.xpi for addon {5d49fde5-fd9a-4584-8bf1-9c20268be5e2}"
[task 2025-04-12T12:08:32.748Z] 12:08:32     INFO -  (xpcshell/head.js) | test run_next_test 10 pending (2)
[task 2025-04-12T12:08:32.748Z] 12:08:32     INFO -  (xpcshell/head.js) | test test_permissions_prompt finished (2)
[task 2025-04-12T12:08:32.748Z] 12:08:32     INFO -  xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | Starting test_normalized_optional_origins
[task 2025-04-12T12:08:32.749Z] 12:08:32     INFO -  (xpcshell/head.js) | test test_normalized_optional_origins pending (2)
[task 2025-04-12T12:08:32.749Z] 12:08:32     INFO -  "Test normalized optional origins on non-privileged ManifestV2 extension"
[task 2025-04-12T12:08:32.749Z] 12:08:32     INFO -  (xpcshell/head.js) | test run_next_test 10 finished (2)
[task 2025-04-12T12:08:32.749Z] 12:08:32     INFO -  "Wait for the install prompt"
[task 2025-04-12T12:08:32.749Z] 12:08:32     INFO -  TEST-PASS | xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_normalized_optional_origins - [test_normalized_optional_origins : 637] Extension should not be installed yet - null == null
[task 2025-04-12T12:08:32.750Z] 12:08:32     INFO -  TEST-PASS | xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_normalized_optional_origins - [test_normalized_optional_origins : 642] Permission handler was invoked - {"existingAddon":null,"addon":{},"icon":"chrome://mozapps/skin/extensions/extensionGeneric.svg","install":{"installId":3}} != "undefined"
[task 2025-04-12T12:08:32.750Z] 12:08:32     INFO -  TEST-PASS | xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_normalized_optional_origins - [test_normalized_optional_origins : 643] Permission info includes the new addon - {} != null
[task 2025-04-12T12:08:32.750Z] 12:08:32     INFO -  TEST-PASS | xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_normalized_optional_origins - [test_normalized_optional_origins : 644] Expect the addon to be non-privileged - false == false
[task 2025-04-12T12:08:32.751Z] 12:08:32     INFO -  TEST-PASS | xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_normalized_optional_origins - [test_normalized_optional_origins : 650] userPermissions are correct - {"permissions":["tabs"],"origins":[],"data_collection":[]} deepEqual {"permissions":["tabs"],"origins":[],"data_collection":[]}
[task 2025-04-12T12:08:32.751Z] 12:08:32  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.toml:toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js | test_normalized_optional_origins - [test_normalized_optional_origins : 655] optionalPermissions are correct - {"permissions":[],"origins":["http://*.example.com/","http://*.example.com/somepath/","*://example.org/*","*://example.org/another-path/*","file://*/*"],"data_collection":[]} deepEqual {"permissions":[],"origins":["http://*.example.com/","http://*.example.com/somepath/","*://example.org/*","*://example.org/another-path/*","file://*/*"]}
[task 2025-04-12T12:08:32.752Z] 12:08:32     INFO -  /opt/worker/tasks/task_174445849944460/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js:assertAddonWrapperPermissionsProperties:655
[task 2025-04-12T12:08:32.752Z] 12:08:32     INFO -  exiting test
[task 2025-04-12T12:08:32.752Z] 12:08:32     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2025-04-12T12:08:32.752Z] 12:08:32     INFO -  _abort_failed_test@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:869:20
[task 2025-04-12T12:08:32.752Z] 12:08:32     INFO -  do_report_result@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:981:5
[task 2025-04-12T12:08:32.753Z] 12:08:32     INFO -  Assert<@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:70:21
[task 2025-04-12T12:08:32.753Z] 12:08:32     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:251:10
[task 2025-04-12T12:08:32.753Z] 12:08:32     INFO -  deepEqual@resource://testing-common/Assert.sys.mjs:331:8
[task 2025-04-12T12:08:32.753Z] 12:08:32     INFO -  assertAddonWrapperPermissionsProperties@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js:655:14
[task 2025-04-12T12:08:32.753Z] 12:08:32     INFO -  async*test_normalized_optional_origins@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_webextension_install.js:702:9
[task 2025-04-12T12:08:32.754Z] 12:08:32     INFO -  _run_next_test/<@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:1759:22
[task 2025-04-12T12:08:32.754Z] 12:08:32     INFO -  _run_next_test@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:1759:38
[task 2025-04-12T12:08:32.754Z] 12:08:32     INFO -  run@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:808:9
[task 2025-04-12T12:08:32.754Z] 12:08:32     INFO -  _do_main@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:245:6
[task 2025-04-12T12:08:32.754Z] 12:08:32     INFO -  _execute_test@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:596:5
[task 2025-04-12T12:08:32.754Z] 12:08:32     INFO -  @-e:1:1
[task 2025-04-12T12:08:32.755Z] 12:08:32     INFO -  exiting test
[task 2025-04-12T12:08:32.755Z] 12:08:32     INFO -  "CONSOLE_MESSAGE: (info) 1744459712647	addons.repository	DEBUG	cacheAddons: enabled false IDs ["{30e8f15f-7e8a-4a93-8996-a9cd2dca76fa}"]"
[task 2025-04-12T12:08:32.755Z] 12:08:32     INFO -  "Force a GC"
[task 2025-04-12T12:08:32.755Z] 12:08:32     INFO -  Error: Found unexpected files in temporary directory: generated-extension-7.xpi at resource://testing-common/AddonTestUtils.sys.mjs:363
[task 2025-04-12T12:08:32.755Z] 12:08:32     INFO -  init/<@resource://testing-common/AddonTestUtils.sys.mjs:363:15
[task 2025-04-12T12:08:32.755Z] 12:08:32     INFO -  _execute_test/<@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:660:28
[task 2025-04-12T12:08:32.756Z] 12:08:32     INFO -  async*_execute_test@/opt/worker/tasks/task_174445849944460/build/tests/xpcshell/head.js:669:5
[task 2025-04-12T12:08:32.756Z] 12:08:32     INFO -  @-e:1:1
[task 2025-04-12T12:08:32.756Z] 12:08:32     INFO -  <<<<<<<

Comment 4

[William Durand [:willdurand]]

Sorry about that, I missed this test.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a6769a440f9
Show data collection permissions in the update prompt.  r=rpl,fluent-reviewers,bolsson

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/2a6769a440f9

Comment 7

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (140.0a1/20250507164202) under Windows 11 and Ubuntu 24.04 LTS.

Updating from the “none” data type to a required data type will prompt the user and the new data collection permission will be shown in the update dialog. See attached screenshot.

Updating from the “none” data type to the T&I optional data type will not prompt the user and the update will be automatically applied.

Updating from a required or optional data type to the “none” data type will not prompt the user and the update will be automatically applied.

Comment 8

[Alex Cornestean]

Attachment: 2025-05-08_11h40_21.png