195782 - Login cookies don't work right with Safari

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Daniel Berlin]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-us) AppleWebKit/62 (like Gecko) Safari/62
Build Identifier: 

If you use Safari with bugzilla, it continually asks you to login. It is actually setting the cookie, but the login name it puts in the cookie has a space in front of it, so when it looks it up again, it can't find it.

The cause is this line in CGI.pl:
print "Set-Cookie: Bugzilla_login= " . url_quote($enteredlogin) . " ; path=$cookiepath; expires=Sun, 30-Jun-2029 00:00:00 GMT\n";

If you change it to:
print "Set-Cookie: Bugzilla_login=" . url_quote($enteredlogin) . " ; path=$cookiepath; expires=Sun, 30-Jun-2029 00:00:00 GMT\n";



everything works fine.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Dave Miller [:justdave]]

confirmed.

Comment 2

[Dave Miller [:justdave]]

I bet Safari is sending the leading space back as part of the cookie content...

Comment 3

[Dave Miller [:justdave]]

Attachment: Patch

removes leading space from the cookie value

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 116151 [details] [diff] [review]
Patch

this is actually already included in the Auth.pm patch.  I'll dupe in a moment.

Comment 5

[Dave Miller [:justdave]]

Setting dependency on the Auth.pm bug.  That's about to land, and the patch
there already fixes this.

Comment 6

[Bradley Baetz (:bbaetz)]

Our cookies stuff is fragile. Using CGI.pm on that stuff is on my list after the
Auth patch goes in.

Comment 7

[Bradley Baetz (:bbaetz)]

Fixed as part of the auth reorg.

hyatt: since mozilla, ie, and ns4 (not to mention lynx, links, and several
others) support this, you probably want to support this for safari....

Comment 8

[Dave Miller [:justdave]]

*** Bug 200374 has been marked as a duplicate of this bug. ***

Comment 9

[Bradley Baetz (:bbaetz)]

Dave, this isn't fixed on bmo yet, it appears (using an apple loan laptop at linux.conf.au). Any 
chance of applying this manually?