1957857 - [DevTools Release Tasks - Cycle 139] Remove backward compatibility code

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

https://searchfox.org/mozilla-central/search?path=&q=%40backward-compat%20%7B%20version%20137%20%7D

Comment 1

[Julian Descottes [:jdescottes]]

https://searchfox.org/mozilla-central/rev/e339b9d6175e30310f6891a5e85d27ce43ad94f1/devtools/server/actors/root.js#138-143

// @backward-compat { version 137 } Process Descriptor's `getWatcher()`
// supports a new 'enableWindowGlobalThreadActors' flag to enable
// the WindowGlobal's thread actors when debugging the whole browser.
// Once 137 is released, we may keep this flag to help VS.Code know
// which backend supports this feature or not.
supportsEnableWindowGlobalThreadActors: true,

One of the backward compatibility items for this release is unclear.
Alex, Holger, should we keep this trait?

Comment 2

[Holger Benl [:hbenl]]

(In reply to Julian Descottes [:jdescottes] from comment #1)

https://searchfox.org/mozilla-central/rev/e339b9d6175e30310f6891a5e85d27ce43ad94f1/devtools/server/actors/root.js#138-143

// @backward-compat { version 137 } Process Descriptor's `getWatcher()`
// supports a new 'enableWindowGlobalThreadActors' flag to enable
// the WindowGlobal's thread actors when debugging the whole browser.
// Once 137 is released, we may keep this flag to help VS.Code know
// which backend supports this feature or not.
supportsEnableWindowGlobalThreadActors: true,

One of the backward compatibility items for this release is unclear.
Alex, Holger, should we keep this trait?

Yes, the VS Code extension needs it to know that the 'enableWindowGlobalThreadActors' flag is available.
Once all versions of Firefox (including ESR!) support it, I will update the extension to always use it and then we can remove the trait.

Comment 3

[Julian Descottes [:jdescottes]]

Once all versions of Firefox (including ESR!) support it, I will update the extension to always use it and then we can remove the trait.

Thanks I'll update the comment to remove it when Firefox 143 is released then, that's when ESR 140 will be the only ESR available.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1957857 - [devtools] Remove backward compatibility code for cycle 139

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb569ae96901
[devtools] Remove backward compatibility code for cycle 139 r=devtools-reviewers,ochameau

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/bb569ae96901