1958006 - [wpt-sync] Sync PR 51801 - layout: Restrict stretch alignment to flex items with computed auto size

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 51801 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51801
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

layout: Restrict stretch alignment to flex items with computed auto size

We were allowing align-self: stretch to stretch flex items whose cross size behaves as auto, including cyclic percentages.

However, https://github.com/w3c/csswg-drafts/issues/4525 resolved that stretching should only happen when the cross size computes to auto.

So this patch exposes this information in ContentBoxSizesAndPBM, and refactors the flexbox stretching logic.

Testing: ?????
Fixes: #<!-- nolink -->36285

Reviewed in servo/servo#36288

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a29fe4f0c4ce36453226e007f80616264d7eb21

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8060e6d55f0
[wpt PR 51801] - layout: Restrict stretch alignment to flex items with computed auto size, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b8060e6d55f0