1958099 - Consider using a larger text size on the share list

Status: RESOLVED FIXED

(Firefox for Android :: Share, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

We have a couple linter warnings in our Fenix baseline regarding the font size being used on various share lists:

<issue
    id="SmallSp"
    message="Avoid using sizes smaller than `11sp`: `10sp`"
    errorLine1="        android:textSize=&quot;10sp&quot;"
    errorLine2="        ~~~~~~~~~~~~~~~~~~~~~~~">
    <location
        file="src/main/res/layout/account_share_list_item.xml"
        line="39"
        column="9"/>
</issue>

<issue
    id="SmallSp"
    message="Avoid using sizes smaller than `11sp`: `10sp`"
    errorLine1="        android:textSize=&quot;10sp&quot;"
    errorLine2="        ~~~~~~~~~~~~~~~~~~~~~~~">
    <location
        file="src/main/res/layout/app_share_list_item.xml"
        line="37"
        column="9"/>
</issue>

If nothing else, maybe we should annotate these two instances to ignore the linter warning rather than relying on the baseline if we're convinced this is the right font size to use. What are your thoughts, Jon?

Comment 1

[Jonathan Almeida [:jonalmeida]]

Yeah, that sounds good - the lowest effort option today. We are following the original designs for the size before the linter came out, I wouldn't bother fixing this today with an impending share sheet rewrite happening.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1958099 - Ignore share sheet font size lint warnings.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d719ef3c336
Ignore share sheet font size lint warnings. r=android-reviewers,jonalmeida

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2d719ef3c336