1958424 - Android H.264 SW encoder breaks gtest cases.

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect)

Description

[John Lin [:jhlin][:jolin]]

In bug 1870519, H264Specific::mFormat was introduced to instruct the encoder to generate AnnexB or AVCC format bitstream but AndroidDataEncoder hasn't been updated and still uses Usage::Realtime/Record to determine the output format.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1958424 - use H264BitStreamFormat in AndroidDataEncoder. r=chunmin

Comment 2

[John Lin [:jhlin][:jolin]]

Besides the bitstream format issue, AndroidDataEncoder doesn't report frame duration, either. Changing the bug summary to include it.

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1958424 - set output frame duration in AndroidDataEncoder.

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1958424 - skip tests for Android SW H.264 encoder. r=chunmin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a35f2e69ba3
use H264BitStreamFormat in AndroidDataEncoder. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/d72dd03bfcd5
set output frame duration in AndroidDataEncoder. r=media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/ed2332904996
skip tests for Android SW H.264 encoder. r=chunmin

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7a35f2e69ba3
https://hg.mozilla.org/mozilla-central/rev/d72dd03bfcd5
https://hg.mozilla.org/mozilla-central/rev/ed2332904996