1958625 - RFP: manage bookmarks | undocked console are sized to fill screen

Status: ASSIGNED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Thorin [:thorin]]

regression from Bug 1951690 - Variant 2 - Rescale top level window on Windows if RoundWindowSize is active

STR

• open FF, go to about config, type in resist, make sure RFP is false
• open console, make sure it is a separate window (i.e, not docked), and it should be windowed
• close console
• flip RFP to true
• open console - it is now full sized screen, not maximized (note the decoration)
• close console
• flip RFP to false
• open console - it is now back to your expected windowed size

expected: console should not be resized or have anything to do with RFP

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1951690

Comment 2

[Thorin [:thorin]]

FYI: it also does the same with manage bookmarks window - might be some others

Comment 3

[Fatih Kilic [:fkilic]]

Does this require an immediate fix or can it stay for a while (beyond 140 possibly)? Window sizing is really convoluted. I'm not sure if I can get to this issue before all the other stuff I'm assigned. If it does require a solution before 140, then I say we backout bug 1951690, and try to fix this issue some other way.

Comment 4

[Thorin [:thorin]]

Makes debugging etc annoying as hell (and you don't want the noise and duplicate bugzillas flooding your way if this lands in stable) so I personally would prefer it was fixed (I've never encountered the issue in bug 1951690 so IDK if rolling back if ok or not). Maybe ask tjr?

Comment 5

[Fatih Kilic [:fkilic]]

Maybe ask tjr?

Sure.

Hello Tom, what do you think we should do? Solving bug 1951690 caused this issue. We don't have a lot of properties to decide if we want to resize or not here. We may check for schema and not resize if it is chrome://. I haven't tested this though (I'll have to switch to a windows machine and my win machine is slow), so I'm not sure if it will work.

We can also consider backing out https://phabricator.services.mozilla.com/D241419 and landing https://phabricator.services.mozilla.com/D241406.

Comment 6

[Tom Ritter [:tjr]]

I would back out the patch.

Comment 7

[Fatih Kilic [:fkilic]]

Attachment: Bug 1958625: Back out bug 1951690. r?tjr

Comment 8

[Thorin [:thorin]]

This is fixed by the back out. Do you want to close this and retry everything in Bug 1951690, or keep this open and change the description to engineer the window principal? - fkilic or tjr