1958711 - Clean up gfxWindowsSurface and related code.

Status: RESOLVED FIXED

(Core :: Widget: Win32, task, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1958711 - Clean up gfxWindowsSurface. r=#win-reviewers,#gfx-reviewers

mWnd is always null, mOwnsDc is always false.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1958711 - Remove unused BufferMode on FallbackRenderer. r=#gfx-reviewers,tnikkel

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1958711 - Minor clean-ups to nsWindow::OnPaint. r=#win-reviewers

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1958711 - Unify fallback and regular painting codepaths in nsWindow::OnPaint. r=#win-reviewers

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1958711 - Remove reentrancy from nsWindow::OnPaint. r=#win-reviewers

I don't think this should be needed. Painting shouldn't trigger new
invalidations (and nowadays most of the actual compositing doesn't
happen here anyways).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5caf7f6f3392
Clean up gfxWindowsSurface. r=gfx-reviewers,nical

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9709a0c5b59c
Remove unused BufferMode on FallbackRenderer. r=win-reviewers,handyman

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/5caf7f6f3392
https://hg.mozilla.org/mozilla-central/rev/9709a0c5b59c

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36851e1b6d05
Minor clean-ups to nsWindow::OnPaint. r=win-reviewers,handyman

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/36851e1b6d05

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf0bc7f835ba
Unify fallback and regular painting codepaths in nsWindow::OnPaint. r=win-reviewers,handyman

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3eae8d62c807
Remove reentrancy from nsWindow::OnPaint. r=win-reviewers,handyman

Comment 13

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/cf0bc7f835ba
https://hg.mozilla.org/mozilla-central/rev/3eae8d62c807