1958790 - Can't reorder newsgroups in folder tree

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Francesco]

In TB 128 it's possible to re-order newsgroup in the folder tree via drag and drop. This no longer works in TB 138 beta (EDIT: TB 137 beta). Bug 1846550 isn't on beta yet, so it can't be the cause.

Comment 1

[Francesco]

Alice, can you find the regression? For example, add news.eternal-september.org as a news server (no login required), subscribe to a few newsgroups and try to reorder them in the folder list.

Comment 2

[Alice0775 White]

Regression window:
https://hg-edge.mozilla.org/comm-central/pushloghtml?fromchange=4948575003009f049032b4511f44e8b489e655d6&tochange=66028cdf41bf03bacd6284cbb1f1028fab046812
https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=4a47e8749bb583587549908437477b44909fe4fd&tochange=63a925452bfab6acf4f52f72d892c55c257b1c3e

Comment 3

[Francesco]

Thank you so much, Alice! Looks like bug 1881087 disabled too much.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1958790 - Allow newsgroups to be re-ordererd in folder tree again. r=#thunderbird-reviewers

Re-enable limiting away nntp in https://hg-edge.mozilla.org/comm-central/rev/eec2c8c99c5f#l1.745

Testing this I noticed JavaScript error: chrome://messenger/content/about3Pane.js, line 3468: TypeError: can't access property "dataset", row.closest(...) is null so fixing that at the same time.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/da82ca780f5b
Allow newsgroups to be re-ordered in folder tree again. r=vineet

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9477700 [details]
Bug 1958790 - Allow newsgroups to be re-ordererd in folder tree again. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Regression
• User impact if declined: Can't reorder newsgroups
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very contained fix
• String changes made/needed: none

Comment 7

[Corey Bryant]

Comment on attachment 9477700 [details]
Bug 1958790 - Allow newsgroups to be re-ordererd in folder tree again. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 138.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/ae5533260106