19588 - [feature] Dragging containers (folders) in a toolbar

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P1)

Description

[Chris McAfee]

Personal toolbar.
Select pulldown, drag (not click) your way to
a submenu, crash.  Pink saw this on mac,
I see this on linux.

Comment 1

[Chris McAfee]

correction, linux seems Ok, I was seeing this with
11/18 NT build.

Comment 2

[Mike Pinkerton (not reading bugmail)]

accepting.

Comment 3

[Mike Pinkerton (not reading bugmail)]

p1 for m12. people see this a lot trying to use those submenus. here is the stack
trace:

PowerPC access exception at 0CA5C740
 Calling chain using A6/R1 links
  Back chain  ISA  Caller
  092F08DE    68K  015F29D6  'proc BF7F 0002'+00796
  092F08BE    68K  015F2822  'proc BF7F 0002'+005E2
  092F08A0    68K  015F274A  'proc BF7F 0002'+0050A
  092F083F    PPC  0040E32C  EmToNatEndMoveParams+00014
  092F07C0    PPC  0CCDF1C0  nsMacWindow::DragReceiveHandler(GrafPort*, void*,
OpaqueDragRefe
rence*)+00098
  092F0750    PPC  0CCE04B8  nsMacWindow::DragEvent(unsigned int, Point, unsigned
short)+0005
C
  092F06F0    PPC  0CCE1AEC  nsMacEventHandler::DragEvent(unsigned int, Point,
unsigned short
)+002CC
  092F0610    PPC  0CCC7598  nsWindow::DispatchMouseEvent(nsMouseEvent&)+00060
  092F05B0    PPC  0CCC7434  nsWindow::DispatchWindowEvent(nsGUIEvent&)+00028
  092F0570    PPC  0CCC7340  nsWindow::DispatchEvent(nsGUIEvent*, nsEventStatus&
)+000A8
  092F0520    PPC  0C4A5180  HandleEvent(nsGUIEvent*)+00064
  092F04D0    PPC  0C4A18DC  nsViewManager::DispatchEvent(nsGUIEvent*,
nsEventStatus&)+007C4
  092F02F0    PPC  0C4A70F4  nsView::HandleEvent(nsGUIEvent*, unsigned int,
nsEventStatus&, i
nt&)+00160
  092F0270    PPC  0C4A7184  nsView::HandleEvent(nsGUIEvent*, unsigned int,
nsEventStatus&, i
nt&)+001F0
 Closing log

adding beard as crash appears in view manager.

Comment 4

[Mike Pinkerton (not reading bugmail)]

checked in a temp fix to disallow dragging of containers in the personal toolbar.
You get the previous behavior now, but this still has some serious issues. There
is the crash on mac/win32 and it hoses up the drag manager something fierce on
mac once you try to drag into one of these popup menus.

moving off to m13, but this is still serious.

Comment 5

[Peter Trudelle]

drag&drop is once again post-beta according to marketing. moving all d&d bugs to
M15.

Comment 6

[Claudius Gayle]

just noting to myself that this is no longer evident from a user perspective on all paltfroms
with the 200001913 builds.

Comment 7

[Mike Pinkerton (not reading bugmail)]

it's cuz i turned off d&d yesterday on all platforms ;) ;)

Comment 8

[leger]

Adding "crash" keyword to all known open crasher bugs.

Comment 9

[Peter Trudelle]

no time for this in the current release, resolving as later.

Comment 10

[Peter Trudelle]

reopening all latered bugs

Comment 11

[Peter Trudelle]

Moving all latered bugs to M20 as ordered by project manager.  Although these 
bugs are now open, assigned and targetted, XPToolkit has no plans to 
fix/implement them in the current release cycle, if ever.

Comment 12

[Peter Trudelle]

Mass move of all M20 bugs to M30.

Comment 13

[Peter Trudelle]

Mass moving M20 bugs to M30

Comment 14

[Peter Trudelle]

Mass-moving all M20-M30 XPToolkit bugs to Future

Comment 15

[Mike Pinkerton (not reading bugmail)]

This will be tricky, given that the popups spring down immediately on mousedown.
Perhaps I can bulid the equivalent of WaitMouseMoved() in JS as an XP solution
to this all over the app.

While this would be nice, I think we can leave it for 1.0, as long as we have
the ability to drop things on containers and drag single items around.

Comment 16

[Jesse Ruderman]

I've found that it's very easy to accidentally drag items on toolbars that I 
intended to click, or that I wasn't trying to interact with at all, and this 
makes the UI of Windows taskbar and Internet Explorer feel unstable.  How about 
requiring that the user hold alt to drag items?  That would take care of 
the "instability" and the problem of not being able to drag folders on the 
personal toolbar, although it might make it harder to discover that the items 
can be dragged around.

Comment 17

[Mike Pinkerton (not reading bugmail)]

fffffffuture

Comment 18

[Jesse Ruderman]

WFM.  I can Alt+drag a folder on the personal toolbar folder in both Mozilla and
Phoenix on WinXP.