195898 - All editor entry points should be protected by nsAutoUpdateViewBatch

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[leon.zhang]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0

to prevent caret flying around

Reproducible: Always

Steps to Reproduce:

Comment 1

[leon.zhang]

The related functions include: insert/delete/undo/redo/cut/paste/drop of 
ensEditor/nsPlainTextEditor/nsHTMLEdior.

1) insert: 
   This entry point has been protected  by nsAutoPlaceHolderBatch(in
nsHTMLEditor::TypedText) and nsEditor::InsertTextIntoTextNodeImpl, both of which
embed function of nsAutoUpdateViewBatch
2) delete:
   This entry point has been protected  by nsAutoPlaceHolderBatch(in
nsPlaintextEditor::DeleteSelection) which embed function of nsAutoUpdateViewBatch
3) Paste:
   This entry point has been protected  by
nsAutoPlaceHolderBatch(nsHTMLEditor::InsertFromTransferable -> nsAutoEditBatch)
and nsEditor::InsertTextIntoTextNodeImpl, both of which embed function of
nsAutoUpdateViewBatch
4) Drop:
   This entry point has been protected  by
nsHTMLEditor::InsertFromDrop(->nsAutoEditBatch -> nsAutoPlaceHolderBatch) and
nsEditor::InsertTextIntoTextNodeImpl,both of which embed function of
nsAutoUpdateViewBatch.
5) Dndo/Redo:
   These two entry points have been protected  by nsAutoUpdateViewBatch.

btw,I traced and get info above using maileditor(html and plaintext format) and
composer.

Comment 2

[leon.zhang]

since, current codes have done these functions. 
so close it

Comment 3

[sairuh (rarely reading bugmail)]

rs vrfy.