1959407 - Moving pinned tab when they are overflowing will not keep the moved tab in view after area is scrolled

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 1-2 May]]

Attachment: expand_move_pin.gif

Found in

• 138.0b5

Affected versions

• 139.0a1 (2025-04-08)
• 138.0b5

Tested platforms

• Affected platforms: Windows 10x64, macOS. Ubuntu 24
• Unaffected platforms: none

Preconditions

• sidebar enabled
• vertical tab enabled
• sidebar placed on the left side
• expand on hover enabled

Steps to reproduce

1. Pin multiple tabs until they overflow.
2. Move one pinned tab from the top to the bottom.

Expected result

• The pinned tab is kept in view.

Actual result

• The pinned tab is removed from view.

Regression range

• This happens after the implementation of the scrollbar for the pinned tabs (bug 1954990). I will set it as the regressor. Please remove it if you feel otherwise.

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sclements, since you are the author of the regressor, bug 1954990, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1959407 - Use scrollPosition instead of scrollTop for vertical-pinned-tabs-container r=#tabbrowser-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb2c0705c5ed
Use scrollPosition instead of scrollTop for vertical-pinned-tabs-container r=tabbrowser-reviewers,sthompson

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fb2c0705c5ed

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 1-2 May]]

Verified fixed with 139.0a1 (2025-04-24) on Windows 10x64, macOS 12 and Ubuntu 24.04. The pinned tabs are correctly kept in view while moved, and they overflow.