Closed Bug 1959438 Opened 13 days ago Closed 13 days ago

Duplicating a tab just to the left of a tab group causes the tab to appear overtop of the tab label

Categories

(Firefox :: Tabbed Browser, defect, P1)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
139 Branch
Tracking Flags:
Tracking Status
firefox-esr128 --- unaffected
firefox137 --- unaffected
firefox138 --- verified
firefox139 --- verified

People

(Reporter: jswinarton, Assigned: jswinarton)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-tabgrps-tabbrowser])

Attachments

(3 files)

tab-overtop.mov
3.76 MB, video/quicktime
Details
Bug 1959438: Prevent tab from entering tab group label DOM element on tab insert r?dao,dwalker,sthompson
48 bytes, text/x-phabricator-request
Details | Review
Bug 1959438: Prevent tab from entering tab group label DOM element on tab insert r?dao,dwalker,sthompson
48 bytes, text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details | Review
Attached video tab-overtop.mov —
No description provided.
Assignee: nobody → jswinarton
Severity: -- → S3
Points: --- → 2
Keywords: regression
Priority: -- → P1
Regressed by: 1957723
Blocks: 1907099
Whiteboard: [fidefe-tabgrps-tabbrowser]

Set release status flags based on info from the regressing bug 1957723

status-firefox137: --- → unaffected
status-firefox138: --- → unaffected
status-firefox139: --- → affected
status-firefox-esr128: --- → unaffected
Attachment #9478033 - Attachment description: WIP: Bug 1959438: Prevent tab from entering tab group label DOM element on tab insert → Bug 1959438: Prevent tab from entering tab group label DOM element on tab insert r?dao,dwalker,sthompson
Pushed by jswinarton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1ac598af5141 Prevent tab from entering tab group label DOM element on tab insert r=sthompson,tabbrowser-reviewers

https://hg.mozilla.org/mozilla-central/rev/1ac598af5141

Status: NEW → RESOLVED
Closed: 13 days ago
status-firefox139: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
Attachment #9478268 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: If a user duplicates a tab to the left of a tab group, the resulting tab will break the tab strip.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: Create a tab group with at least one tab in it. Select the tab that is directly to the left of the group (but that is not inside the group). Right click the tab and select "duplicate tab".
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Adds only a single check and the surrounding code is well tested.
  • String changes made/needed: None
  • Is Android affected?: no
Flags: qe-verify+

Comment on attachment 9478268 [details]
Bug 1959438: Prevent tab from entering tab group label DOM element on tab insert r?dao,dwalker,sthompson

Approved for 138.0b6

Attachment #9478268 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified fixed on Nightly 139.0a1 (20250410163733) and Beta 138.0b6 (20250410212121).

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
status-firefox138: fixed → verified
status-firefox139: fixed → verified
Flags: qe-verify+
Duplicate of this bug: 1959468
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: