195945 - XSLT generated pages render in quirks mode

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

When starting to create real HTML-documents we also ended up render in quirks
mode. This is bad! Patch comming up.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to explicitly set standards mode

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 116224 [details] [diff] [review]
patch to explicitly set standards mode

sr=me, but could we fix SetCompatibilityMode to notify _all_ the prescontexts,
please?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

sure, but i'd rather not do that here as i was hoping to land this patch on the
1.3 branch. I'd hate it if people started relying on quirks mode in XSLT

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 116224 [details] [diff] [review]
patch to explicitly set standards mode

Though you could set htmlDoc at the start of the function, where you set
mDocumentIsHTML. Up to you.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 116224 [details] [diff] [review]
patch to explicitly set standards mode

This patch should be safe. As usual it's only limited to XSLT-generated pages.

The reason I want this in the 1.3 release is that I don't want people to get
used to quirks-mode in XSLT.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in on trunk

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Have you tested the various tests in http://dbaron.org/mozilla/tests/compat to
see that you're setting the mode in all of the places that it's stored with the
function call you're using?

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I had only ran my own tests, but it passes yours too. (except that I of course
couldn't run the comment-parsing test).

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

without this patch we are compleatly in quirks mode

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in on branch too

Comment 11

[Axel Hecht]

mass verifying