Consider merging our vendorings of chromium such as security/sandbox/ and third_party/zucchini/
Categories
(Firefox Build System :: General, task)
Tracking
(Not tracked)
People
(Reporter: yannis, Unassigned)
Details
For the needs of bug 1632374 we are vendoring yet another instance of chromium in third_party/zucchini/, with (quite many) files that we already vendor in security/sandbox/. Right now this is being reviewed in bug 1946753. During the code review, it was suggested that we could consider merging the common files, in particular those in base/, to have a single vendoring of chromium.
Merging the two vendorings would mostly have benefits at the source tree level, giving a more harmonious source tree with less duplicates, thereby making it easier to be sure we're looking at the right file when looking for something. It would also make it easier to integrate security fixes from upstream chromium.
Merging would not mean smaller binaries because security/sandbox/ ends up in firefox.exe while third_party/zucchini/ ends up in updater.exe.
Merging would introduce coupling between the sandbox and zucchini, meaning that it would be impossible to update the sandbox code independently from zucchini and vice versa (in practice, zucchini doesn't get updated very often). It introduces a risk that updating the common vendoring to catch up with the latest sandbox changes could now negatively impact updates, which could result in dramatic outcomes if our tests are not solid enough to detect the issue.
Because of the last paragraph, I'm not sure we actually want to do this merging. I think that having coupling between updater.exe and the rest of our code might be something that we are already trying to avoid. What do you think, :bytesized?
Independently of the final decision, I don't think that now is the right time to do the merging, because there is a big sandbox update in parallel in bug 1937025 and we don't want to delay the progress on zucchini by having it depend on the sandbox update and vice versa.
|
Reporter | |
Comment 1•9 days ago
|
||
I encountered a network error and ended up submitting the bug twice.
Description
•