Closed Bug 1959664 Opened 16 days ago Closed 14 days ago

[wpt-sync] Sync PR 51935 - corner-shape: remove curvature adjustment

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
139 Branch
Tracking Flags:
Tracking Status
firefox139 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51935 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51935
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

corner-shape: remove curvature adjustment

Curvature adjustment created the illusion that the border had
consistent thickness.

However, the thicker the border, the closer the inner curvature came
to scoop/straight, and stopped resembling the original shape.

Undoing the curvature adjustment - as having a bit of a belly in the
very high/low curvatures is better than not having an inner shape.

Bug: 399449172
Change-Id: I84da4f36b10edbf1fa3f3f8a3b6270e5dc9c440f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6443779
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1445212}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 16 days ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 22 tests

Status Summary

Firefox

PASS: 3
FAIL: 19

Chrome

PASS: 18
FAIL: 4

Safari

PASS: 3
FAIL: 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 22 tests

Status Summary

Firefox

PASS: 3
FAIL: 19

Chrome

PASS: 18
FAIL: 4

Safari

PASS: 3
FAIL: 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 22 tests

Status Summary

Firefox

PASS: 3
FAIL: 19

Chrome

PASS: 18
FAIL: 4

Safari

PASS: 3
FAIL: 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 22 tests

Status Summary

Firefox

PASS: 3
FAIL: 19

Chrome

PASS: 18
FAIL: 4

Safari

PASS: 3
FAIL: 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d53406ea841 [wpt PR 51935] - corner-shape: remove curvature adjustment, a=testonly https://hg.mozilla.org/integration/autoland/rev/8464286c44be [wpt PR 51935] - Update wpt metadata, a=testonly

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 22 tests

Status Summary

Firefox

PASS: 3
FAIL: 19

Chrome

PASS: 18
FAIL: 4

Safari

PASS: 3
FAIL: 19

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/9d53406ea841
https://hg.mozilla.org/mozilla-central/rev/8464286c44be

Status: REOPENED → RESOLVED
Closed: 16 days ago → 14 days ago
status-firefox139: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
You need to log in before you can comment on or make changes to this bug.