1959748 - Identity pane code does not unnest about: URIs correctly, breaking assertion

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Malte Jürgens [:maltejur]]

Spinning off from Bug 1956178, the changes from Bug 1864464 seem to break this assertion. Quoting myself:

My changes from Bug 1864464 definitely seem wrong in that regard. It seems with them, about: URIs always get completely unnested to their moz-safe-about: inner URI, which is not expected by the code, and also generally seems wrong.

Comment 1

[Malte Jürgens [:maltejur]]

Attachment: Bug 1959748 - Do not unnest about: URIs in site identity pane r?Gijs

The E10SUtils.getAboutModule used later in the code does not expect
moz-safe-about: URIs, which some about: URIs would get unnested to.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1864464

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f91f638a5a3
Do not unnest about: URIs in site identity pane r=Gijs

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2f91f638a5a3

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:maltejur, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.