Closed Bug 1959756 Opened 19 days ago Closed 16 days ago

[wpt-sync] Sync PR 51939 - [animation-trigger] Restrict ActionAnimation to PhaseAndTime changes

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
139 Branch
Tracking Flags:
Tracking Status
firefox139 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51939 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51939
Details from upstream follow.

David Awogbemila <awogbemila@chromium.org> wrote:

[animation-trigger] Restrict ActionAnimation to PhaseAndTime changes

Iterating over all of AnimationTimeline's animations every frame could
be wasteful and affect performance. Instead, we can restrict the calls
to ActionAnimations to only when the phase and time of a progress-based
timeline change. This doesn't change any web-observable behavior.

[1] https://source.chromium.org/chromium/chromium/src/+/c239defb88a349021dbb583622ac6809154d9547:third_party/blink/renderer/core/animation/animation_timeline.cc;l=99-103

Bug: 390314945, 405085123
Change-Id: Id3231cc99d71896470a14732e9b27387d0ca078a
Reviewed-on: https://chromium-review.googlesource.com/6431774
WPT-Export-Revision: c4a4fa54e1728286a4c577f42249a1fa2fd137e1

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /scroll-animations/animation-trigger/animation-trigger-late-attached-timeline.tentative.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
    • late-attached trigger timeline plays animation: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/61c8cd896d07 [wpt PR 51939] - [animation-trigger] Restrict ActionAnimation to PhaseAndTime changes, a=testonly

https://hg.mozilla.org/mozilla-central/rev/61c8cd896d07

Status: NEW → RESOLVED
Closed: 16 days ago
status-firefox139: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
You need to log in before you can comment on or make changes to this bug.