Closed Bug 1959790 Opened 15 days ago Closed 13 days ago

Fix the schema of the glean Ping markers

Categories

(Toolkit :: Telemetry, defect)

defect

Tracking

()

RESOLVED FIXED
139 Branch
Tracking Status
firefox139 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

The current marker schema for Glean pings looks broken:

            schema.set_tooltip_label("{marker.data.cat}.{marker.data.id} {marker.data.reason}");
            schema.set_table_label(
                "{marker.name} -{marker.data.cat}.{marker.data.id} {marker.data.reason}",
            );
  • marker.data.cat doesn't exist for ping markers
  • there's a missing space after '-' in the table label, meaning the profiler front-end can't strip the "{marker.name} - " prefix
  • additionally, the "Ping" schema name is too generic.

Example profiles with the broken schema and with the fixed one.

Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9102251c9b73 Fix the schema of the glean Ping markers, r=chutten.
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: