Closed Bug 1959803 Opened 13 days ago Closed 8 days ago

High frequency browser/base/content/test/general/browser_datachoices_notification.js | Must have a timer callback. - false == true -

Categories

(Firefox :: Tabbed Browser, defect, P5)

defect
Points:
1

Tracking

()

RESOLVED FIXED
139 Branch
Iteration:
139.2 - Apr 14 - Apr 25
Tracking Status
firefox-esr128 --- unaffected
firefox137 --- wontfix
firefox138 --- fixed
firefox139 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mviar)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: intermittent-failure, intermittent-testcase, regression)

Attachments

(2 files, 1 obsolete file)

Filed by: agoloman [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=503366517&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/AV95qsnySveNQ-3oYGsFdA/runs/0/artifacts/public/logs/live_backing.log


[task 2025-04-10T18:58:08.257Z] 18:58:08     INFO - TEST-PASS | browser/base/content/test/general/browser_datachoices_notification.js | User should not be allowed to upload. - true == true - 
[task 2025-04-10T18:58:08.258Z] 18:58:08     INFO - Buffered messages finished
[task 2025-04-10T18:58:08.259Z] 18:58:08     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_datachoices_notification.js | Must have a timer callback. - false == true - 
[task 2025-04-10T18:58:08.259Z] 18:58:08     INFO - Stack trace:
[task 2025-04-10T18:58:08.259Z] 18:58:08     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_datachoices_notification.js:triggerInfoBar:90
[task 2025-04-10T18:58:08.259Z] 18:58:08     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_datachoices_notification.js:test_single_window:183
[task 2025-04-10T18:58:08.259Z] 18:58:08     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-04-10T18:58:08.259Z] 18:58:08     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-04-10T18:58:08.259Z] 18:58:08     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-04-10T18:58:08.259Z] 18:58:08     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-04-10T18:58:08.259Z] 18:58:08     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-04-10T18:58:08.260Z] 18:58:08     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-04-10T18:58:08.261Z] 18:58:08     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_datachoices_notification.js | Timeout should match - null == 10000 - 
[task 2025-04-10T18:58:08.261Z] 18:58:08     INFO - Stack trace:
[task 2025-04-10T18:58:08.261Z] 18:58:08     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_datachoices_notification.js:triggerInfoBar:92
[task 2025-04-10T18:58:08.261Z] 18:58:08     INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_datachoices_notification.js:test_single_window:183
[task 2025-04-10T18:58:08.261Z] 18:58:08     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-04-10T18:58:08.261Z] 18:58:08     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-04-10T18:58:08.261Z] 18:58:08     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-04-10T18:58:08.261Z] 18:58:08     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-04-10T18:58:08.261Z] 18:58:08     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-04-10T18:58:08.262Z] 18:58:08     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-04-10T18:58:08.264Z] 18:58:08     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_datachoices_notification.js | Uncaught exception in test bound test_single_window - at chrome://mochitests/content/browser/browser/base/content/test/general/browser_datachoices_notification.js:94 - TypeError: showInfobarCallback is not a function
[task 2025-04-10T18:58:08.264Z] 18:58:08     INFO - Stack trace:
[task 2025-04-10T18:58:08.264Z] 18:58:08     INFO - triggerInfoBar@chrome://mochitests/content/browser/browser/base/content/test/general/browser_datachoices_notification.js:94:3
[task 2025-04-10T18:58:08.264Z] 18:58:08     INFO - async*test_single_window@chrome://mochitests/content/browser/browser/base/content/test/general/browser_datachoices_notification.js:183:9
[task 2025-04-10T18:58:08.264Z] 18:58:08     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1170:26
[task 2025-04-10T18:58:08.264Z] 18:58:08     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1242:18
[task 2025-04-10T18:58:08.264Z] 18:58:08     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1383:14
[task 2025-04-10T18:58:08.264Z] 18:58:08     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1159:14
[task 2025-04-10T18:58:08.264Z] 18:58:08     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2025-04-10T18:58:08.265Z] 18:58:08     INFO - Leaving test bound test_single_window
[task 2025-04-10T18:58:08.266Z] 18:58:08     INFO - Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "chrome://browser/content/spotlight.html" line: 0}]
[task 2025-04-10T18:58:08.426Z] 18:58:08     INFO - GECKO(8268) | MEMORY STAT | vsize 2120869MB | vsizeMaxContiguous 67591017MB | residentFast 467MB | heapAllocated 197MB
[task 2025-04-10T18:58:08.427Z] 18:58:08     INFO - TEST-OK | browser/base/content/test/general/browser_datachoices_notification.js | took 535ms

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Tabbed Browser

Started to investigate this bug since it is failing really often as seen here.

Here are a few retriggers and backfills:

  • bc1 on Linux 18.04 x64 WebRender opt - link
  • bc7 on Linux 18.04 x64 WebRender debug - link
  • bc11 on OS X 10.15 WebRender debug - link

:mviar could your push be the cause for this frequent failure? Can you please take a look?

If not, I suspect one more push that could be the culprit: https://bugzilla.mozilla.org/show_bug.cgi?id=1958294#c4

Flags: needinfo?(mviar)
Summary: Intermittent browser/base/content/test/general/browser_datachoices_notification.js | single tracking bug → High frequency browser/base/content/test/general/browser_datachoices_notification.js | Must have a timer callback. - false == true -

@mviar, can you take a look at these high frequency failures?
backfills and retriggers indicate it's coming from bug 1952000

Keywords: regression
Keywords: leave-open
Attachment #9478844 - Attachment description: Bug 1959803 - Disable browser_datachoices_notification.js on linux/mac/win until for frequent failures r=#intermittent-reviewers → Bug 1959803 - Disable browser_datachoices_notification.js on linux/mac/win for frequent failures r=#intermittent-reviewers

Thanks for flagging Sandor. I've attached a patch to address the issue. The 1% rollout patch was uplifted into 137, so we may need to uplift this fix as well.

Flags: needinfo?(mviar)
Assignee: nobody → mviar
Iteration: --- → 139.2 - Apr 14 - Apr 25
Points: --- → 1
Attachment #9478844 - Attachment is obsolete: true
Keywords: leave-open
Whiteboard: intermittent-failure, intermittent-testcase, regression
Pushed by mviar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e64913c5f50 High frequency browser/base/content/test/general/browser_datachoices_notification.js | Must have a timer callback. r=omc-reviewers,negin
Status: NEW → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch

The patch landed in nightly and beta is affected.
:mviar, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(mviar)
Attachment #9479409 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: None (but developers would continue to see the high frequency failure on beta)
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: n/a
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Only changes an automated test, there should be no user impact
  • String changes made/needed: no
  • Is Android affected?: no

Uplift requested

Flags: needinfo?(mviar)
Attachment #9479409 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: