1959848 - Cannot delete chat accounts

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect, P1)

Description

[Aurelia]

Steps to reproduce:

create a new chat account
try to delete the account

Actual results:

no response to pressing delete button

Expected results:

I should be able to delete the account

Comment 1

[Magnus Melin [:mkmelin]]

Indeed, that doesn't work. Thanks for reporting! Presumably fallout from bug 1904229.

Uncaught TypeError: source[methodName] is not a function
    getAccountValue chrome://messenger/content/AccountManager.js:1395
    restorePage chrome://messenger/content/AccountManager.js:1439
    onPanelLoaded chrome://messenger/content/AccountManager.js:1236
    <anonymous> chrome://messenger/content/am-im.js:18
AccountManager.js:1395:55
    getAccountValue chrome://messenger/content/AccountManager.js:1395
    restorePage chrome://messenger/content/AccountManager.js:1439
    onPanelLoaded chrome://messenger/content/AccountManager.js:1236
    <anonymous> chrome://messenger/content/am-im.js:18

Uncaught TypeError: can't access property "incomingServer", currentAccount is null
    onRemoveAccount chrome://messenger/content/AccountManager.js:894
    oncommand chrome://messenger/content/am-im.xhtml:1
2 AccountManager.js:894:18
    onRemoveAccount chrome://messenger/content/AccountManager.js:894
    oncommand chrome://messenger/content/am-im.xhtml:1

Comment 2

[Martin Giger [:freaktechnik]]

I think this is actually a regression from bug 1946011 - at least the stack we get when loading the page. The password is still being loaded as wstring, but that no longer works.

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1959848 - Fix chat account settings by replacing wstring with string. r=#thunderbird-reviewers

Bug 1946011 made it so wstring is now just string.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b35065a4d57d
Fix chat account settings by replacing wstring with string. r=aleca