Fix a BasePluginConvention type deprecation warning
Categories
(Firefox for Android :: Tooling, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox139 | --- | fixed |
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 file)
Most of these were fixed in bug 1880848, but one more usage slipped in afterwards.
|
Assignee | |
Comment 1•16 days ago
|
||
|
||
Comment 3•15 days ago
|
||
| bugherder | ||
|
||
Comment 4•10 days ago
|
||
(In reply to Pulsebot from comment #2)
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a650ae242df7
Fix one more BasePluginConvention type deprecation warning.
r=adhingra,android-reviewers
Hi Ryan!
Do you think the push mentioned in the comment below is responsible for the performance regression mentioned in the alert summary ? This performance regression is for a critical test and we'll need to confirm if this push is the culprit. There is also the previous push, associated with Bug 1959846 which may be responsible for the regression, but we cannot confirm, since we are unable to run the necessary jobs for that push.
Perfherder has detected a mozperftest performance change from push a650ae242df7580cad14e6c7d084523916c2f79f. As author of one of the patches included in that push, we need your help to address this regression.
Please acknowledge, and begin investigating this alert within 3 business days, or the patch(es) may be backed out in accordance with our regression policy. Our guide to handling regression bugs has information about how you can proceed with this investigation.
If you have any questions or need any help with the investigation, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 8% | newssite-applink-startup org.mozilla.fenix:tab-cpu-time | android-hw-a55-14-0-aarch64-shippable | 1,737.67 -> 1,881.00 |
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 24% | newssite-applink-startup applink_startup | android-hw-a55-14-0-aarch64-shippable | 2,461.58 -> 1,864.57 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.
You can run all of these tests on try with ./mach try perf --alert 44730
The following documentation link provides more information about this command.
|
|
Assignee | |
Comment 5•10 days ago
|
||
No, the patch shouldn't have any net effect on the resulting builds. From the alert text above, bug 1959846 seems more plausible.
Description
•