1960027 - Remove JS_HAS_TEMPORAL_API

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[André Bargull [:anba]]

Temporal is now enabled by default (bug 1912511), so let's remove JS_HAS_TEMPORAL_API. This is also prerequisite to share some currently duplicated code for Intl which implements the same functionality as Temporal. The preference for Temporal won't be removed as part of this bug.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1960027 - Part 1: Always enable icu_calendar when ICU4X is used. r=#spidermonkey-reviewers!

Removes the separate "icu4x_calendar" feature and instead enables "icu_calendar"
by default.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1960027 - Part 2: Remove JS_HAS_TEMPORAL_API in JS_HAS_INTL_API code. r=#spidermonkey-reviewers!

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1960027 - Part 3: Replace JS_HAS_TEMPORAL_API with JS_HAS_INTL_API. r=#spidermonkey-reviewers!

When JS_HAS_INTL_API is defined, then ICU4C and ICU4X are available, which are
both required to build Temporal.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1960027 - Part 4: Remove JS_HAS_TEMPORAL_API and --with-temporal-api. r=#spidermonkey-reviewers!

Actually remove JS_HAS_TEMPORAL_API and the "--with-temporal-api" configure option.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af8c4bd712c4
Part 1: Always enable icu_calendar when ICU4X is used. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/194efde0efa6
Part 2: Remove JS_HAS_TEMPORAL_API in JS_HAS_INTL_API code. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/38cc3665a824
Part 3: Replace JS_HAS_TEMPORAL_API with JS_HAS_INTL_API. r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/408fb399a602
Part 4: Remove JS_HAS_TEMPORAL_API and --with-temporal-api. r=spidermonkey-reviewers,dminor

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/af8c4bd712c4
https://hg.mozilla.org/mozilla-central/rev/194efde0efa6
https://hg.mozilla.org/mozilla-central/rev/38cc3665a824
https://hg.mozilla.org/mozilla-central/rev/408fb399a602