1960271 - bug in regexp from bug 1955372 (plain http: won't be accepted)

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Magnus Melin [:mkmelin]]

There is a bug in the regexp for bug 1927449. https: will be accepted but plain http: will not.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1960271 - Fix bug in regexp from bug 1955372 (plain http: won't be accepted). r=kaie

Comment 2

[Kai Engert [:KaiE:]]

wrong bug # reference ? did you want 1955372 ?

Comment 3

[Magnus Melin [:mkmelin]]

Indeed, bug 1955372!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7c220f953430
Fix bug in regexp from bug 1955372 (plain http: won't be accepted). r=kaie

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9478825 [details]
Bug 1960271 - Fix bug in regexp from bug 1955372 (plain http: won't be accepted). r=kaie

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Regression
• User impact if declined: http enclosures won't load (but https will)
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One liner
• String changes made/needed: none

Comment 6

[Corey Bryant]

Comment on attachment 9478825 [details]
Bug 1960271 - Fix bug in regexp from bug 1955372 (plain http: won't be accepted). r=kaie

[Triage Comment]
This will be included in 139.0b1 after the merge. We can uplift to release and esr128 after.

Comment 7

[Corey Bryant]

Comment on attachment 9478825 [details]
Bug 1960271 - Fix bug in regexp from bug 1955372 (plain http: won't be accepted). r=kaie

See esr128 uplift request

Comment 8

[Corey Bryant]

Assuming we don't need another CVE for this.

Comment 9

[Magnus Melin [:mkmelin]]

Yeah it's just a bug.

Comment 10

[Corey Bryant]

Comment on attachment 9478825 [details]
Bug 1960271 - Fix bug in regexp from bug 1955372 (plain http: won't be accepted). r=kaie

[Triage Comment]
Approved for release
Approved for esr128

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 138.0.1:
https://hg.mozilla.org/releases/comm-release/rev/c9b8794ebaf5

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 128.10.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/cea3005312f8