1960299 - broken-site-report ping should be marked as a gecko ping, it is send on Fenix too

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean Platform, enhancement, P1)

Description

[Jan-Erik Rediger [:janerik]]

The broken-site-report ping is send from both Desktop and Android.
That wasn't always the case and that's why bug 1940030 moved the definition files to be firefox-desktop specific.
Bug 1956012 tried to correct that, but due to where the data is set we need to have separate metric defintion files.
However the ping is the same across both platforms, but not labeled as such.

That's currently no problem.

1. Due to the state of things before bug 1940030 the tables were created and all data continues to be ingested
2. The dictionary doesn't display the ping state.

However (2) is about to change as I plan to show whether a ping was removed, and now the broken-site-report ping will be shown as such when it isn't. So we should correct how it's scraped.

Comment 1

[Jan-Erik Rediger [:janerik]]

Ok, I think this is more a bug in how the dictionary combines the data.
The ping is declared here for Fenix: https://searchfox.org/mozilla-central/rev/4d00b50c42a788c51ac4c5fe92b684569ba6c3a5/mobile/android/fenix/app/pings.yaml#239

So I think the Dictionary uses the gecko definition, when it should use the Fenix definition.

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: [mozilla/glean-dictionary] Bug 1960299 - Glean ETL: Have the app override any dependency-defined ping (#2290)

Comment 3

[Jan-Erik Rediger [:janerik]]

Yup, this is a dictionary issue. Which above PR would fix.

Comment 4

[Jan-Erik Rediger [:janerik]]

badboy merged PR [mozilla/glean-dictionary]: Bug 1960299 - Glean ETL: Have the app override any dependency-defined ping (#2290) in f267da8.