comment in nsDoubleHashtable suggests const modifier for keys already in the macros

RESOLVED WONTFIX

Status

()

Core
XPCOM
RESOLVED WONTFIX
15 years ago
5 years ago

People

(Reporter: Axel Hecht, Unassigned)

Tracking

Trunk
x86
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

15 years ago
nsDoubleHashtable.h has a good comment on it's usage, but one little bug.
 * (2) Create the hash class
 *
 * The final hash class you will use in step 3 is defined by 2 macros.
 *
 * DECL_DHASH_WRAPPER(Dictionary, DictionaryEntry, const nsAString&)
 * DHASH_WRAPPER(Dictionary, DictionaryEntry, const nsAString&)

should be

 * DECL_DHASH_WRAPPER(Dictionary, DictionaryEntry, nsAString&)
 * DHASH_WRAPPER(Dictionary, DictionaryEntry, nsAString&)

as the const modifier is already in the macro definition.

Following this gives bogus warnings.
Assignee: john → nobody
QA Contact: scc → xpcom

Comment 1

5 years ago
Please just remove doublehash, if it isn't already gone.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.