1960556 - Implement dialog `requestClose`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Keith Cirkel [:keithamus]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Adds requestClose() to Dialog elements
[Affects Firefox for Android]: Yes
[Suggested wording]: Added requestClose() to HTMLDialogElement.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/requestClose

Comment 1

[Keith Cirkel [:keithamus]]

Attachment: Bug 1960556 - Implement Dialog requestClose r?#dom-core

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bf58ecf3d6d
Implement Dialog requestClose r=webidl,smaug

Comment 3

[pstanciu]

Backed out for causing wpt failures on dialog-requestclose.html

• https://hg.mozilla.org/integration/autoland/rev/e79e8fe53bcb2b048aa64b04abd8b04dc714b22a
• Push with failures
• Failure Log

Comment 4

[Keith Cirkel [:keithamus]]

Thanks, I'll take a look.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4863fcfe00ad
Implement Dialog requestClose r=webidl,smaug

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/52132 for changes under testing/web-platform/tests

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4863fcfe00ad

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx139 relnotes.

Comment 10

[Hamish Willee]

Does this/do we also support the associated dialog element closedby attribute?

Comment 11

[Keith Cirkel [:keithamus]]

(In reply to Hamish Willee from comment #10)

Does this/do we also support the associated dialog element closedby attribute?

https://bugzilla.mozilla.org/show_bug.cgi?id=1936940 tracks the addition of closedby - which will be released separately. This bug is just the .requestClose() method.

Comment 12

[Hamish Willee]

FF139 MDN docs for this tracked from https://github.com/mdn/content/issues/39307