1960638 - Load PiP video-wrappers from jar:/file: instead of moz-extension:

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, task, P1)

Description

[Tom Schuster (MoCo)]

We only want Services.scriptloader.loadSubScript to load trusted schemes, but PiP seems to currently use this function to load video wrappers that are part of the [e-mail] WebExtension. As a bit of a hack, we can just resolve these wrapper scripts using the underlying jar: or file: URLs of the extension. This seems to be the only use of loadSubScript with the moz-extension: protocol, otherwise I would have probably looked into a different solution.

Comment 1

[Tom Schuster (MoCo)]

Attachment: Bug 1960638 - Load PiP video-wrappers from jar:/file: instead of moz-extension:. r?#pip-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37354cbce77a
Load PiP video-wrappers from jar:/file: instead of moz-extension:. r=pip-reviewers,mconley

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/37354cbce77a