1960646 - [wpt-sync] Sync PR 52001 - Remove ComputeDotsPerPixel from CSSPrimitiveValue

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52001 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52001
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Remove ComputeDotsPerPixel from CSSPrimitiveValue

Fixes a crash issue with sibling-index() in resolution calc()
expressions in image-set() by not supporting parsing them for now, but
pass in a CSSLengthResolver in all cases we can.

Issue 410746569 is about storing computed resolution values for
image-set()s on ComputedStyle.

Bug: 408399392, 408234457, 410746569
Change-Id: I51a4ee997dfd0d13e5ce669b11080f93b5eabf67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6432954
Commit-Queue: Rune Lillesveen \<[e-mail]>
Reviewed-by: Daniil Sakhapov \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1447057}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd8187e596c9794eaa4ae09ea99c9cfeb5ef1dcb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 142 subtests

Status Summary

Firefox

OK : 1
PASS: 138
FAIL: 4

Chrome

OK : 1
PASS: 142

Safari

OK : 1
PASS: 140
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-images/image-set/image-set-parsing.html [wpt.fyi]
  • e.style['background-image'] = "image-set(url("example.png") calc(1dppx * sign(1em - 10px)))" should set the property value: FAIL
  • e.style['background-image'] = "-webkit-image-set(url("example.png") calc(1dppx * sign(1em - 10px)))" should set the property value: FAIL

New Tests That Don't Pass

• /css/css-images/image-set/image-set-parsing.html [wpt.fyi]
  • e.style['background-image'] = "image-set(url("example.png") calc(1dppx * sibling-index()))" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['background-image'] = "-webkit-image-set(url("example.png") calc(1dppx * sibling-index()))" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['background-image'] = "image-set(url("example.png") calc(1dppx * sign(1em - 10px)))" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
  • e.style['background-image'] = "-webkit-image-set(url("example.png") calc(1dppx * sign(1em - 10px)))" should set the property value: FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6694109b5188
[wpt PR 52001] - Remove ComputeDotsPerPixel from CSSPrimitiveValue, a=testonly
https://hg.mozilla.org/integration/autoland/rev/5fcd292962f6
[wpt PR 52001] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6694109b5188
https://hg.mozilla.org/mozilla-central/rev/5fcd292962f6