1960978 - In new Settings > Appearance, Unthreaded/Threaded doesn't work

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect, P2)

Description

[robert.funnell]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:137.0) Gecko/20100101 Firefox/137.0

Steps to reproduce:

Go to Settings > Appearance
Select Unthreaded instead of Threaded
Click on 'Propagate threading and sorting settings to: All existing folders'.

Actual results:

Nothing seemed to happen, the threaded messages were still displayed as threaded

Expected results:

I expected threaded messages in my Inbox to no longer be displayed as threaded

If I click on the 'Message list display options' icon, go to 'Sort by', and change between Threaded and Unthreaded, then the message display changes, but the new setting is not reflected in the new Appearance section.

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:137.0) Gecko/20100101 Firefox/137.0

Comment 1

[Alessandro Castellani [:aleca]]

I'm investigating this, thanks for the report

Comment 2

[Michel]

The "threaded/unthreaded/grouped by sort" switch in "Settings > Appearance" only sets the default .
The next folder you create will have this setting, it will not be applied to all currently existing folders.

Comment 3

[Michel]

The switch only sets the default, that is not a bug, apply to all folders should work though.

Comment 4

[robert.funnell]

Michel, you're right, I made a mistake in including the sentence 'If I click on … ' in my report.

Comment 5

[Alessandro Castellani [:aleca]]

(In reply to robert.funnell from comment #0)

Click on 'Propagate threading and sorting settings to: All existing folders'.

Can you confirm that if you click on All existing folders button your folders don't get any of the new settings?
Does it happen even if you select another folder and go back to the previous one?

If I click on the 'Message list display options' icon, go to 'Sort by', and change between Threaded and Unthreaded, then the message display changes, but the new setting is not reflected in the new Appearance section.

Yeah, that's normal as the Message list display options only affect the currently visible folder and not all folders.
We will need to fix that strange UX in the future.

Comment 6

[robert.funnell]

(In reply to Alessandro Castellani [:aleca] from comment #5)

Can you confirm that if you click on All existing folders button your folders don't get any of the new settings?
I confirm this.
Does it happen even if you select another folder and go back to the previous one?
If I select another folder and go back to the previous one, then I do see the new Threaded/Unthreaded setting.

If I click on the 'Message list display options' icon, go to 'Sort by', and change between Threaded and Unthreaded, then the message display changes, but the new setting is not reflected in the new Appearance section.

Yeah, that's normal as the Message list display options only affect the currently visible folder and not all folders.
We will need to fix that strange UX in the future.
The behaviour does make sense once it's pointed out, but it's not clear that I'd ever want threading for some folders and not for others.

Thank you for your attention to this.

Comment 7

[Alessandro Castellani [:aleca]]

Attachment: Bug 1960978 - Ensure that currently selected folder is refreshed when database flags are changed. r=#thunderbird-reviewers

How to test

• Select a folder and set it a threaded.
• Open Settings > Appearance, change default view to unthreaded.
• Click "Apply all".
• Confirm that the currently selected folder was properly refreshed and shows the correct view.

This always worked but I wasn't properly refreshing the message list but only invalidating the visible range.
The tests also only covered the actual database flags but not the UI and widget attribute changes.

Comment 8

[Alessandro Castellani [:aleca]]

I confirmed the issue and implemented a fix.
The options were properly saved in the folder database but I wasn't correctly reloading the currently selected folder so the UI was showing a stale list.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d000c490409e
Ensure that currently selected folder is refreshed when database flags are changed. r=tobyp

Comment 10

[robert.funnell]

Thanks! It works nicely in Daily :-)

Comment 11

[Michel]

Not quite yet, threaded/unthreaded works ok, but grouped by sort sets everything unthreaded.

Comment 12

[Alessandro Castellani [:aleca]]

(In reply to Michel from comment #11)

Not quite yet, threaded/unthreaded works ok, but grouped by sort sets everything unthreaded.

That's how Grouped by Sort works as unfortunately we don't currently support threads for that option.
You could open a request for improvements bug with this (if we don't have one already).

Comment 13

[Michel]

Sorry, I wasn't quite clear, apparently.
If I choose grouped by sort > apply to all (or any) folder(s), those folders should be set grouped by sort.
Right now, they are set unthreaded.

Comment 14

[Alessandro Castellani [:aleca]]

Oh sorry, I misunderstood.
Could you open a bug report and needinfo me on that one so i can investigate?
Thank you