1961061 - Update android nightly application-services version bump to new version 6a007c98292fa72965d36389ce32d7609e399217 from 2025-04-17 00:37:37

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement)

Description

[Update Bot]

This update covers 3 commits. Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

6a007c98292fa72965d36389ce32d7609e399217 by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/6a007c98292fa72965d36389ce32d7609e399217
Authored: 2025-04-16 15:49:27 -0700
Committed: 2025-04-16 23:26:47 +0000

Bug 1960786 - Dismiss AMP suggestions by full keyword instead of URL

This adds SuggestStore::dismiss, which takes a Suggestion, and deprecates
SuggestStore::dismiss_suggestion, which takes a URL.

It also makes one other substantive change: If an AMP suggestion doesn't have
full_keywords defined in its RS data, then Suggestion.full_keyword will now
be an empty string instead of a string computed at query time from its keywords.

The problem with using such a computed "full keyword" as the dismissal key is
that it's not stable. It's just the prefix of one of the suggestion's keywords
up to the next full word after the query string, so it changes the more you
type.

When the RS data doesn't have a full_keywords, I set Suggestion.full_keyword
to an empty string and then fall back to the suggestion's URL as the dismissal
key. In practice, all AMP suggestions have full keywords in the RS data (I
checked), and going forward with the new AMP API that won't change, so we
shouldn't ever hit this to begin with.

Other possible ways to address this:

• Change the query-time full keyword calculation so that the longest matching
  keyword is used as the full keyword. That might actually be good for UX too,
  maybe not in all cases.
• Add a Suggestion member called is_full_keyword_from_db or something (like
  the similarly named variable in the AMP fetch function), and then we'd use the
  URL as the dismissal key if is_full_keyword_from_db is false.

These are both more complex than setting full_keywords to an empty string and
using that to tell if the dismissal key should be the URL, and since we
shouldn't ever hit this anyway, I didn't bother.

Files Modified:

• components/suggest/src/db.rs
• components/suggest/src/schema.rs
• components/suggest/src/store.rs
• components/suggest/src/suggestion.rs
• components/suggest/src/testing/data.rs
• components/suggest/src/testing/mod.rs

---

70e8e4fc003c2007c2daeeba1cea78c516ea905f by Ryan VanderMeulen <[e-mail]>

https://github.com/mozilla/application-services/commit/70e8e4fc003c2007c2daeeba1cea78c516ea905f
Authored: 2025-04-16 11:47:08 -0400
Committed: 2025-04-16 17:14:16 +0000

Update AndroidX Core to version 1.16.0

Files Modified:

• gradle/libs.versions.toml

---

a93dfea340f1520252986a87ae897dfc594b2bff by Ryan VanderMeulen <[e-mail]>

https://github.com/mozilla/application-services/commit/a93dfea340f1520252986a87ae897dfc594b2bff
Authored: 2025-04-16 11:45:33 -0400
Committed: 2025-04-16 17:14:16 +0000

Compile with Android SDK 36

Files Modified:

• build.gradle
• settings.gradle
• taskcluster/docker/linux/Dockerfile

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=61bbef9736da60a57091824ea9d5dd40249823c7

Comment 2

[Update Bot]

Attachment: Bug 1961061 - Update android nightly application-services version bump to 6a007c98292fa72965d36389ce32d7609e399217

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a28747ce2d4e
Update android nightly application-services version bump to 6a007c98292fa72965d36389ce32d7609e399217 r=release-managers,RyanVM

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (Possible Intermittents):

• test-apk-fenix-debug - 1 of 4 failed on the same (retriggered) task (failed: CdWKni7TQle8Rrx5NnVD5A)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a28747ce2d4e