1961130 - UI not fully translated when using langpack

Status: NEW

(Core :: Internationalization: Localization, defect)

Description

[Jan Horak [:jhorak]]

Attachment: fail.png

When user installs additional langpack some of the buttons are not correctly translated. See the screenshot.
Reproduction steps:

1. put cs langpack xpi into the distribution/extensions (but it's not cs langpack specific)
2. set intl.locale.requested to empty string
3. Run firefox by: LC_ALL="cs_CZ.utf8 firefox"
4. Try to quit firefox to get a prompt.

Looks like the the problem lies in nsStringBundle.cpp where
when the intl:app-locales-changed observer calls flushBundleCache which removes only some of the mBundleMap keys. Records which are not cached (which are not in mBundleCache) and are in the mBundleMap are not cleared.
In my case only following cache records are flushed:

resource://gre/res/locale/layout/HtmlForm.properties
resource://gre/res/locale/dom/dom.properties
chrome://global/locale/intl.properties

There's rest of mBundleMap content:

Key: chrome://global/locale/dom/dom.properties
Key: chrome://global/locale/svg/svg.properties
Key: chrome://global/locale/security/security.properties
Key: chrome://global/locale/commonDialogs.properties
Key: chrome://global/locale/layout/HtmlForm.properties
Key: chrome://global/locale/css.properties
Key: chrome://global/locale/layout_errors.properties
Key: chrome://global/locale/printing.properties
Key: chrome://global/locale/mathml/mathml.properties
Key: chrome://necko/locale/necko.properties
Key: chrome://global/locale/xul.properties
Key: chrome://global/locale/layout/htmlparser.properties
Key: chrome://branding/locale/brand.properties

Calling mBundleMap.Clear() in for the intl:app-locales-changed observer handler help for me.

Comment 1

[Jan Horak [:jhorak]]

Attachment: Bug 1961130 Clear all bundles in mBundleMap when app locales changes; r=emilio

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:eemeli, could you have a look please?

For more information, please visit BugBot documentation.