1961159 - Unnamed tab groups is saved along with the labelled tab group when creating a tab group from the List All Tabs panel

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: 2025-04-17_16h04_34.mp4

Affected versions

• Firefox Nightly 139.0a1
• Firefox Beta 138.0b8

Affected platforms

• All

Steps to reproduce

1. Open a few sites in tabs
2. From the List All tabs menu select a tab and create a new tab group
3. Open the List all tabs and observe the newly created tab group

Expected result

• Tab Group is created and saved in the List All tabs panel

Actual result

• Unnamed tab groups is saved along with the labelled tab group when creating a tab group from the List All Tabs panel

Regression range

• Will find one asap

Additional notes

• See the attached recording

Comment 1

[Rares Doghi, Desktop QA]

Found a regression range for this issue :

13:26.69 INFO: Last good revision: 524b35624e79f3918216a98f2d9d2caf8be7a182
13:26.69 INFO: First bad revision: 63ada92a1059ffff0799746a69b9f5883ecac9a3
13:26.69 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=524b35624e79f3918216a98f2d9d2caf8be7a182&tochange=63ada92a1059ffff0799746a69b9f5883ecac9a3

It Seems that bug 1953533 is causing this. @Stephen can you please take a look at this issue ?

Comment 2

[Stephen Thompson [:sthompson]]

I can look at this, thanks

Comment 3

[Stephen Thompson [:sthompson]]

Attachment: Bug 1961159 - only refresh TabsList DOM when it is open r=dao,dwalker

If a DOM rebuild was scheduled on a previous frame but the rebuild is no longer needed (e.g. due to the "list all tabs" menu no longer being open) then do not clean up nor populate the DOM.

In bug 1953533 we debounced and delayed full DOM rebuilds of the "list all tabs" menu due to severe performance impacts during event-heavy operations like restoring an entire browser session.

When the "list all tabs" menu is closed, it's supposed to get emptied and stop responding to events. However, it was possible to perform actions in the "list all tabs" menu that would trigger events and close the menu at the same time. The triggered event would schedule a "list all tabs" menu rebuild on the next frame, which would then build the "list all tabs" menu DOM despite the menu being closed. When the menu was reopened, the menu builds the menu DOM by inserting new DOM elements, but since the menu was already built, you end up with a doubled version of the tab strip.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acabc99ab8b4
only refresh TabsList DOM when it is open r=dwalker,tabbrowser-reviewers

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/acabc99ab8b4

Comment 6

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed across platforms in Nightly 139.0a1 (20250424092126).