1961170 - Drag and dropping an allowed and a blocked file for upload will not upload the allowed file

Status: VERIFIED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[Greg Stoll :gstoll]

Found in

• 138.0a1 (2025-03-17)

Affected versions

• 138.0a1 (2025-03-17)

Tested platforms

• Affected platforms: Windows 10x64, Windows 11
• Unaffected platforms: Ubuntu 24, macOS

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view
• Create a distribution folder inside the Firefox folder and paste the policies-1.json to it and then rename it to policies.json
• DLP Agent is running: .\content_analysis_sdk_agent.exe --user --toblock=.*\d{3}-?\d{2}-?\d{4}.* --towarn=.*warn.* --delays=10

Steps to reproduce

1. Drag and drop a blocked and an allowed file to https://codepen.io/gregstoll/full/GRYjjry.

Expected result

• The allowed file should be uploaded per 1950424#c0

Actual result

• All files are blocked.

Regression range

• Not a regression; new implementation (bug 1950424).

Additional notes

• Attached a screen recording.
• The issue reproduces as well when clipboard pasting a blocked and allowed file.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:handyman, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Greg Stoll :gstoll]

Sorry, got my bugs confused.

Comment 4

[Greg Stoll :gstoll]

Attachment: Bug 1961170 part 1 - add autoAcknowledge to CheckFilesInBatchMode() r=#dlp-reviewers!

The new entry point analyzeBatchContentRequest() (added in a later part)
is going to want this parameter.

Comment 5

[Greg Stoll :gstoll]

Attachment: Bug 1961170 part 2 - add AnalyzeBatchContentRequest method r=#dlp-reviewers!

This adds a nsIContentAnalysisBatchResult interface which includes the
allowedFiles that the new method returns. On the C++ side I made the
existing ContentAnalysisActionResult class implement this interface
as well, but I'm not married to this; we could make a separate class
instead.

In practice I kind of doubt that a user on Windows could actually drag
some data that has some files and some non-files, but the code should
handle this case correctly. The non-files control whether the overall
result of the nsIContentAnalysisBatchResult is eAllow or eBlock, and
the files that are allowed will get put in allowedFiles.

Comment 6

[Greg Stoll :gstoll]

Attachment: Bug 1961170 part 1 - add autoAcknowledge to CheckFilesInBatchMode() r=#dlp-reviewers!

The new entry point analyzeBatchContentRequest() (added in a later part)
is going to want this parameter.

Comment 7

[Greg Stoll :gstoll]

Attachment: Bug 1961170 part 2 - add AnalyzeBatchContentRequest method r=#dlp-reviewers!

This adds a nsIContentAnalysisBatchResult interface which includes the
allowedFiles that the new method returns. On the C++ side I made the
existing ContentAnalysisActionResult class implement this interface
as well, but I'm not married to this; we could make a separate class
instead.

In practice I kind of doubt that a user on Windows could actually drag
some data that has some files and some non-files, but the code should
handle this case correctly. The non-files control whether the overall
result of the nsIContentAnalysisBatchResult is eAllow or eBlock, and
the files that are allowed will get put in allowedFiles.

Comment 8

[Greg Stoll :gstoll]

Attachment: Bug 1961170 part 3 - make DispatchToDropTargetAndResumeEndDragSession() take allowedFiles r=#dlp-reviewers!

Comment 9

[Greg Stoll :gstoll]

Attachment: Bug 1961170 part 4 - make DispatchToDropTargetAndResumeEndDragSession() take allowedFilePaths r=#dlp-reviewers!

Ideally aAllowedFilePaths would be an array of nsIFile, but unfortunately
we don't seem to be able to pass nsIFile's over IPC, so pass the paths
instead. This should be fine for Windows but may need more testing or
a better solution if/when we support Mac.

Comment 10

[Greg Stoll :gstoll]

Attachment: Bug 1961170 part 5 - make SendDispatchToDropTargetAndResumeEndDragSession() take allowedFiles r=#dlp-reviewers!

Comment 11

[Greg Stoll :gstoll]

Attachment: Bug 1961170 part 6 - update JS drag and drop code to call AnalyzeBatchContentRequest() and pass allowedFiles r=#dlp-reviewers!

Comment 12

[Greg Stoll :gstoll]

Attachment: Bug 1961170 part 7 - update CA drag and drop tests r=#dlp-reviewers!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55ab0d218137
part 1 - add autoAcknowledge to CheckFilesInBatchMode() r=dlp-reviewers,win-reviewers,handyman
https://hg.mozilla.org/integration/autoland/rev/3fee4b4f2e97
part 2 - add AnalyzeBatchContentRequest method r=dlp-reviewers,handyman
https://hg.mozilla.org/integration/autoland/rev/d65985bc1774
part 3 - make DispatchToDropTargetAndResumeEndDragSession() take allowedFiles r=dlp-reviewers,handyman
https://hg.mozilla.org/integration/autoland/rev/65557232a65f
part 4 - make DispatchToDropTargetAndResumeEndDragSession() take allowedFilePaths r=dlp-reviewers,handyman
https://hg.mozilla.org/integration/autoland/rev/db291af4e23d
part 5 - make SendDispatchToDropTargetAndResumeEndDragSession() take allowedFiles r=dlp-reviewers,handyman
https://hg.mozilla.org/integration/autoland/rev/d41e3c1fae52
part 6 - update JS drag and drop code to call AnalyzeBatchContentRequest() and pass allowedFiles r=dlp-reviewers,reusable-components-reviewers,handyman,hjones
https://hg.mozilla.org/integration/autoland/rev/f284a629b1c1
part 7 - update CA drag and drop tests r=dlp-reviewers,handyman

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/55ab0d218137
https://hg.mozilla.org/mozilla-central/rev/3fee4b4f2e97
https://hg.mozilla.org/mozilla-central/rev/d65985bc1774
https://hg.mozilla.org/mozilla-central/rev/65557232a65f
https://hg.mozilla.org/mozilla-central/rev/db291af4e23d
https://hg.mozilla.org/mozilla-central/rev/d41e3c1fae52
https://hg.mozilla.org/mozilla-central/rev/f284a629b1c1

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! Verified fixed with Firefox 140.0b1 on Windows 10x64. The ALLOWed file is correctly uploaded via drag and drop when a blocked and an allowed file are uploaded.