1961245 - Change reference case for viewBox-synthesized-in-img-001.tentative.html to not use `<embed>` elements

Status: RESOLVED FIXED

(Core :: SVG, task)

Description

[Daniel Holbert [:dholbert]]

See bug 1960606 comment 3 - there seems to be some overhead associated with all the <embed> elements that we're dynamically generating in https://searchfox.org/mozilla-central/rev/60108fa975e0bfa63f3372258030e372414fd0d2/testing/web-platform/tests/svg/coordinate-systems/viewBox-synthesized-in-img-001-ref.html , and that makes the test take on the order of 10-20 seconds on some platforms.

Filing this bug to switch to just using regular HTML for the mockup rather than <embed>-with-subdocuments, to avoid that wasted time and intermitent test-timeouts from this making us occasionally overstep the time limit.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1961245: Change an svg WPT reference case to generate expected rendering using divs, instead of embedded documents. r?longsonr

In a perfect world, it's nice to compare <img> against analogous <embed>
elements and assert that the rendering should match. However, as discussed in
https://bugzilla.mozilla.org/show_bug.cgi?id=1960606#c3 , there's substantial
overhead involved with setting up all of the embed documents. We can make the
test dramatically faster by expressing the expected-rendering using divs,
so that's what this patch does.

Comment 2

[Daniel Holbert [:dholbert]]

Here are logs to show that this drops us from ~16 s to ~1 on Android

Log without this patch:
https://treeherder.mozilla.org/logviewer?job_id=504324732&repo=try&lineNumber=12118

TEST-PASS | /svg/coordinate-systems/viewBox-synthesized-in-img-001.tentative.html | took 16521ms

Log with this patch:
https://treeherder.mozilla.org/logviewer?job_id=504499291&repo=try&lineNumber=12138

TEST-PASS | /svg/coordinate-systems/viewBox-synthesized-in-img-001.tentative.html | took 887ms

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce4c0be4149e
Change an svg WPT reference case to generate expected rendering using divs, instead of embedded documents. r=longsonr

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ce4c0be4149e

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/52093 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot