1961356 - Add back moz.build config to create built_in_addons.json file for MOZ_BUILD_APP "comm/mail" to ensure en-US dictionary is auto-installed in Thunderbird builds

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The last patch in Bug 1949847 patch stack (https://hg-edge.mozilla.org/mozilla-central/rev/597f461ec791) has removed the gen_built_in_addons.py deprecated --feature cli option from the options passed from toolkit/mozapps/extensions/moz.build but along with that has removed the MOZ_BUILD_APP "comm/mail" branch that was creating the built_in_addons.json file for Thunderbird builds.

While Thunderbird did not seem to use the system add-ons part (Bug 1949847 comment 9 and Bug 1949847 comment 10) of the built_in_addons.json file, the built_in_addons.json file still needs to be generated for the "dictionaries" part of it.

That is also highlighted by the xpcshell test failure hit by test_dictionary_webextension.js in Thunderbird build on the sanity check assertion part of the test setup task here: https://searchfox.org/mozilla-central/rev/f3c8c63a097b61bb1f01e13629b9514e09395947/toolkit/mozapps/extensions/test/xpcshell/test_dictionary_webextension.js#21-26

I've verified locally that the patch I'm about to attach to this bugzilla issue does fix that xpcshell-test failure on a local Thunderbird build as expected.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1961356 - Create built_in_addons.json for MOZ_BUILD_APP comm/mail and mobile/android to ensure en-US dictionary is auto-installed also in those builds. r=mixedpuppy!

Comment 2

[Dianna Smith [:diannaS]]

is this actually a p1/s1? not sure this needs to be tracked for 138

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Dianna Smith [:diannaS] from comment #2)

is this actually a p1/s1? not sure this needs to be tracked for 138

Bug 1949847 did land only one day ago on 139, and so this would have not been tracked for 138, the know issue that we are actually fixing is mainly related to Thunderbird, but given that they would not be able to have the default en-US dictionary if we don't fix it on the Gecko side I marked it as P1 to signal that this is something we want to take care of right away in the same Gecko version that has introduced the issue.

Setting S1 was actually done by mistake, given that I set "task" on this ticket because the change that introduced the issue for Thunderbird builds is still nightly only and wasn't yet riding the train (and so I'm setting severity as N/A along with this bugzilla comment).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81295260c22c
Create built_in_addons.json for MOZ_BUILD_APP comm/mail and mobile/android to ensure en-US dictionary is auto-installed also in those builds. r=mixedpuppy

Comment 5

[Alessandro Castellani [:aleca]]

Thank you so much for the support and the speedy fix.
Much appreciated!

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/81295260c22c