1961428 - Move nsGridContainerFrame::CachedBAxisMeasurement to cpp file

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Minor refactoring and cleanup for CachedBAxisMeasurement and surrounding code. See the patch stack for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1961428 Part 1 - Move public override methods in grid container to first declared public section. r?#layout

This patch moves all public override methods declared at the end the grid
container class to the first public section. It is the first step toward
consolidating the grid container's public interface into a single public
section.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1961428 Part 2 - Move nsGridContainerFrame::CachedBAxisMeasurement to cpp file. r?#layout

The grid item cache is an internal implementation detail that does not need to
be exposed in the header. This patch moves CachedBAxisMeasurement to the cpp
file, similar to where nsFlexContainerFrame::CachedBAxisMeasurement lives.
This change also reduces compile time when modifying the cache code.

Since CachedBAxisMeasurement is now hidden, we add a heler
MarkCachedGridMeasurementsDirty to remove CachedBAxisMeasurement::Prop() in
nsIFrame::MarkIntrinsicISizesDirty().

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1961428 Part 3 - Remove unused typedefs in nsGridContainerFrame. r?#layout

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0072254f7f53
Part 1 - Move public override methods in grid container to first declared public section. r=layout-reviewers,dholbert
https://hg.mozilla.org/integration/autoland/rev/3dbe1a3611f5
Part 2 - Move nsGridContainerFrame::CachedBAxisMeasurement to cpp file. r=layout-reviewers,dholbert
https://hg.mozilla.org/integration/autoland/rev/e5f38e86783d
Part 3 - Remove unused typedefs in nsGridContainerFrame. r=layout-reviewers,dholbert

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0072254f7f53
https://hg.mozilla.org/mozilla-central/rev/3dbe1a3611f5
https://hg.mozilla.org/mozilla-central/rev/e5f38e86783d