1961629 - Improve the ergonomics of getExperimentMetaData / getRolloutMetaData

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Description

[Beth Rennie [:beth] (she/her)]

getExperimentMetaData only returns metadata about the active experiment -- if you want metadata about either the active experiment or rollout, you have to call getExperimentMetaData({ featureId }) ?? getRolloutMetaData({ featureId }), which trips people up.

We should unify this into a singular API (and change the name to getEnrollmentMetadata while we're at it -- MetaData is a weird typo)

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Add ExperimentFeature.getEnrollmentMetadata API r?#nimbus-reviewers!,relud

This new API is equivalent to
ExperimentAPI.get{Experiment,Rollout}MetaData() when called with a
featureId. We want to discourage callers from coding for a specific
experiment slug, so we explicitly do not support that with the new API.

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/aboutwelcome r?#omc-reviewers

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter r?#omc-reviewers

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/doh r?#necko-reviewers

Comment 5

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/genai r?mardak

Comment 6

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/pocket r?thecount

Comment 7

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/search r?#search-reviewers

Comment 8

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/sidebar r?#sidebar-reviewers

Comment 9

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/extensions/newtab r?mconley

Comment 10

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in toolkit/components/normandy r?#nimbus-reviewers

Comment 11

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Remove ExperimentAPI.get{Experiment,Rollout}MetaData r?#nimbus-reviewers

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2e89f5ddf10
Add ExperimentFeature.getEnrollmentMetadata API r=relud,nimbus-reviewers,chumphreys

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dccecc938df1
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/aboutwelcome r=omc-reviewers,aminomancer

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c2e89f5ddf10
https://hg.mozilla.org/mozilla-central/rev/dccecc938df1

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5591b71c7d59
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter r=omc-reviewers,aminomancer

Comment 16

[Atila Butkovits]

Backed out for causing failures at browser_asrouter_toast_notification.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/fc7b4496448b902897d45b578ee0e1326d2ce4f3

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5591b71c7d59c5ae2cd27afb21ac3a699e23e8e8&selectedTaskRun=VFDSdrVLT_2tm3O2m2acwA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=505921724&repo=autoland&lineNumber=4097

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c9c6ab50353
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter r=omc-reviewers,aminomancer

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1317b6297268
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/doh r=necko-reviewers,valentin

Comment 19

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6c9c6ab50353
https://hg.mozilla.org/mozilla-central/rev/1317b6297268

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9ddf90ac823
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/genai r=Mardak,firefox-ai-ml-reviewers

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/826e4be205fa
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/pocket r=thecount

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60e0c96e3ae7
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/search r=search-reviewers,jteow

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca4c933e00e0
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/sidebar r=sidebar-reviewers,nsharpley

Comment 24

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b9ddf90ac823
https://hg.mozilla.org/mozilla-central/rev/826e4be205fa
https://hg.mozilla.org/mozilla-central/rev/60e0c96e3ae7

Comment 25

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ca4c933e00e0

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db185bb30c31
Use ExperimentFeature.getEnrollmentMetadata() in browser/extensions/newtab r=mconley,home-newtab-reviewers

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cd870196e61
Use ExperimentFeature.getEnrollmentMetadata() in toolkit/components/normandy r=nimbus-reviewers,relud,chumphreys

Comment 28

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/actors r?#omc-reviewers

Comment 29

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter (again) r?#omc-reviewers

Missed a few occurrences.

Comment 30

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/extensions/newtab (again) r?mconley

Missed a few occurrences.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ac7ad7760bf
Use ExperimentFeature.getEnrollmentMetadata() in browser/actors r=omc-reviewers,aminomancer

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6d62f52f488
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter (again) r=omc-reviewers,aminomancer

Comment 33

[amarc]

https://hg.mozilla.org/mozilla-central/rev/db185bb30c31

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc0fc5a948a4
Revert "Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter (again) r=omc-reviewers,aminomancer" for causing lint failures @ browser_asrouter_experimentsAPILoader.js

Comment 35

[amarc]

Backed out Commit 061b82e for causing lint failures @ browser_asrouter_experimentsAPILoader.js

• Backout link
• Push with failures
• Failure Log

Comment 36

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3957199cc14c
Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter (again) r=omc-reviewers,aminomancer

Comment 37

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3957199cc14c

Comment 38

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5a6ea7475f7
Use ExperimentFeature.getEnrollmentMetadata() in browser/extensions/newtab (again) r=mconley,home-newtab-reviewers

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/598c1ae6583d
Revert "Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/extensions/newtab (again) r=mconley,home-newtab-reviewers"

Comment 40

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_PlacesFeed.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/598c1ae6583d3cb416beceb2f6e5190c496ab273

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/extensions/newtab/test/xpcshell/test_PlacesFeed.js

Comment 41

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36954d292aca
Remove ExperimentAPI.get{Experiment,Rollout}MetaData r=nimbus-reviewers,relud,chumphreys

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01f7ac5c93b0
Revert "Bug 1961629 - Remove ExperimentAPI.get{Experiment,Rollout}MetaData r=nimbus-reviewers,relud,chumphreys"for causing failures at test_PlacesFeed.js.

Comment 43

[Atila Butkovits]

Backed out for for causing failures at test_PlacesFeed.js..

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/01f7ac5c93b0b0013b9569647fb172bf0facd6c1

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=36954d292acad21b0228d6e66d14b43d76a9b898&selectedTaskRun=YOqmV-hGSWCprvdNqnVJTA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=506606525&repo=autoland&lineNumber=2630

Comment 44

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11dda58af2ee
Use ExperimentFeature.getEnrollmentMetadata() in browser/extensions/newtab (again) r=mconley,home-newtab-reviewers

Comment 45

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8ce1e4efa6b
Remove ExperimentAPI.get{Experiment,Rollout}MetaData r=nimbus-reviewers,relud,chumphreys

Comment 46

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/11dda58af2ee
https://hg.mozilla.org/mozilla-central/rev/d8ce1e4efa6b