Closed
Bug 1961715
Opened 20 days ago
Closed 20 days ago
`GitSCM.apply_patch` fails silently for patch application failures
Categories
(Conduit :: Lando, defect, P3)
Conduit
Lando
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sheehan, Assigned: sheehan)
Details
Attachments
(1 file)
In GitSCM.apply_patch, we catch SCMException failures and check if the error message contains error: patch, in which case we can convert them to a PatchConflict exception. When we do this, we do not re-raise exceptions, which causes other failures in patch application to be silently ignored.
We should re-raise other exceptions instead of swallowing them silently.
|
||
Comment 1•20 days ago
|
||
|
|
||
Comment 2•20 days ago
|
||
Authored by https://github.com/cgsheeh
https://github.com/mozilla-conduit/lando/commit/4deba820c6c17006915f378e6e894c50e58504e3
[main] git: re-raise exceptions from Git in apply_patch (Bug 1961715) (#297)
Status: NEW → RESOLVED
Closed: 20 days ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•