1961780 - We're missing checks for canceled compilations in CodeGenerator

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Jan de Mooij [:jandem]]

The main thread can cancel ongoing Ion compilations and it will then wait until these compilations are finished. To support this the Ion backend has to check mir->shouldCancel() regularly, but I just noticed we're missing checks for this in CodeGenerator. This is likely because when off-thread compilation was first implemented, codegen still happened on the main thread.

Code generation can be pretty slow and this means in certain cases we block the main thread longer than we should.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1961780 - Check for canceled compilations in more places in the JIT backend. r?iain!

We were missing shouldCancel checks in CodeGenerator, likely because this step
initially always ran on the main thread.

This patch also adds these checks to some other places. In OptimizeMIR we now
do this consistently after each optimization pass.

Comment 2

[Nicolas B. Pierron [:nbp]]

From what I recall we kept it at the stage level to avoid overhead.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc33277aa0c5
Check for canceled compilations in more places in the JIT backend. r=iain

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dc33277aa0c5