1961841 - [wpt-sync] Sync PR 52036 - LanguageDetector: Implement destroy

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52036 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52036
Details from upstream follow.

Nathan Memmott <[e-mail]> wrote:

LanguageDetector: Implement destroy

Implements destroy() method and destroying when the create abort signal
is aborted.

Fixed: 403649353, 391713056
Change-Id: I1c9161a229b04977c82e6e3c2b06627cbefb6a77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6460964
Commit-Queue: Nathan Memmott \<[e-mail]>
Reviewed-by: Christine Hollingsworth \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1448072}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c33db2ac6505b9cce94216c706176fd6592baaa

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 14 subtests

Status Summary

Firefox

OK : 4
FAIL : 52[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 56[GitHub]

Chrome

TIMEOUT: 8
NOTRUN : 52

Safari

OK : 4
FAIL : 56

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /ai/language_detection/detector.https.tentative.any.serviceworker.html [wpt.fyi]
  • Simple LanguageDetector.availability() call: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • Simple LanguageDetector.detect() call: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create() notifies its monitor on downloadprogress: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.create().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Calling LanguageDetector.destroy() aborts calls to detect and measureInputUsage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create()'s abort signal destroys its LanguageDetector after creation.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.detect() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.detect().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.measureInputUsage() and inputQuota basic usage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.measureInputUsage() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.measureInputUsage().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Creating LanguageDetector with expectedInputLanguages: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • If monitor throws an error, LanguageDetector.create() rejects with that error: FAIL (Chrome: NOTRUN, Safari: FAIL)
• /ai/language_detection/detector.https.tentative.any.html [wpt.fyi]
  • Simple LanguageDetector.availability() call: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • Simple LanguageDetector.detect() call: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create() notifies its monitor on downloadprogress: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.create().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Calling LanguageDetector.destroy() aborts calls to detect and measureInputUsage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create()'s abort signal destroys its LanguageDetector after creation.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.detect() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.detect().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.measureInputUsage() and inputQuota basic usage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.measureInputUsage() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.measureInputUsage().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Creating LanguageDetector with expectedInputLanguages: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • If monitor throws an error, LanguageDetector.create() rejects with that error: FAIL (Chrome: NOTRUN, Safari: FAIL)
• /ai/language_detection/detector.https.tentative.any.sharedworker.html [wpt.fyi]
  • Simple LanguageDetector.availability() call: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • Simple LanguageDetector.detect() call: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create() notifies its monitor on downloadprogress: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.create().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Calling LanguageDetector.destroy() aborts calls to detect and measureInputUsage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create()'s abort signal destroys its LanguageDetector after creation.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.detect() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.detect().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.measureInputUsage() and inputQuota basic usage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.measureInputUsage() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.measureInputUsage().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Creating LanguageDetector with expectedInputLanguages: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • If monitor throws an error, LanguageDetector.create() rejects with that error: FAIL (Chrome: NOTRUN, Safari: FAIL)
• /ai/language_detection/detector.https.tentative.any.worker.html [wpt.fyi]
  • Simple LanguageDetector.availability() call: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • Simple LanguageDetector.detect() call: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create() notifies its monitor on downloadprogress: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.create().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Calling LanguageDetector.destroy() aborts calls to detect and measureInputUsage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.create()'s abort signal destroys its LanguageDetector after creation.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.detect() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.detect().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.measureInputUsage() and inputQuota basic usage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • LanguageDetector.measureInputUsage() call with an aborted signal.: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Aborting LanguageDetector.measureInputUsage().: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • Creating LanguageDetector with expectedInputLanguages: FAIL (Chrome: NOTRUN, Safari: FAIL)
  • If monitor throws an error, LanguageDetector.create() rejects with that error: FAIL (Chrome: NOTRUN, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/400289f4544c
[wpt PR 52036] - LanguageDetector: Implement destroy, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c81c5c194504
[wpt PR 52036] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/400289f4544c
https://hg.mozilla.org/mozilla-central/rev/c81c5c194504