1961881 - Hook up desktop to the dismissal API in the Suggest Rust component

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

It's time to hook up desktop Suggest to the dismissal API in the Rust component. All this time we've continued to use our old pre-Rust API that stores URL digests of dismissed suggestions in browser.urlbar.quicksuggest.blockedDigests. That hasn't been a major problem because dismissals in the Rust component have also been keyed on URL -- until now in bug 1960786, which switched AMP dismissals to being keyed on full keyword.

This is required for AMP geo expansion because it will fix the problem of AMP dismissals reappearing after a day.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1961881 - Hook up desktop to the dismissal API in the Suggest Rust component.

This hooks up desktop to the dismissal API in the Rust component [1] and removes
BlockedSuggestions.

The Rust dismissal API has two ways to dismiss a suggestion: by Suggestion
object and by dismissal key. We use the first one for Rust suggestions and the
second one for other suggestions, like Merino. A dismissal key is just an
arbitrary opaque string token stored in the dismissed-suggestions table in the
Rust component. It's up to consumers (like desktop) to use appropriate dismissal
keys for their non-Rust suggestions.

In order to retain the user's blocked digests that desktop has always recorded
in the quicksuggest.blockedDigests pref, I took advantage of dismissal keys by
migrating each digest to a dismissal key in the Rust component.

[1] See bug 1961412 and https://github.com/mozilla/application-services/pull/6714

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bdf26a45b56
Hook up desktop to the dismissal API in the Suggest Rust component. r=daisuke,settings-reviewers

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2bdf26a45b56