[wpt-sync] Sync PR 52097 - Fix extra parens in sum/product nodes.
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox139 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 52097 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/52097
Details from upstream follow.
Steinar H. Gunderson <sesse@chromium.org> wrote:
Fix extra parens in sum/product nodes.
We already have all the machinery needed to collect sub-nodes from
our binary tree (e.g.((a + b) + c)into {a,b,c}, which is then
further sorted), so when serializing, just use that vector instead
of creating a new binary tree from the sorted result. This fixes
so that we properly write(a + b + c)for sum nodes, and likewise
for product nodes.Bug: 40118274
Change-Id: I4d72228083dad3e9d8adb815aa5afcf1b7d0df36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462191
Reviewed-by: Daniil Sakhapov \<sakhapov@chromium.org>
Commit-Queue: Steinar H Gunderson \<sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1449865}
|
Assignee | |
Comment 1•23 days ago
|
||
|
|
Assignee | |
Updated•23 days ago
|
|
|
Assignee | |
Comment 2•23 days ago
|
||
|
|
Assignee | |
Comment 3•23 days ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 11 subtests
Status Summary
Firefox
OK : 2
PASS: 1077
FAIL: 11
Chrome
OK : 2
PASS: 1066
FAIL: 22
Safari
OK : 2
PASS: 1077
FAIL: 11
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-values/calc-size/animation/calc-size-interpolation-expansion.html [wpt.fyi]
- value at progress 0.75 in animation of "height" from "auto" to "calc-size(any, 0px)":
FAIL(Chrome:FAIL, Safari:FAIL) - value at progress 0.75 in animation of "height" from "0px" to "calc-size(calc-size(min-content, size + 20px), 2 * size)":
FAIL(Chrome:FAIL, Safari:FAIL) - value at progress 0.75 in animation of "height" from "calc-size(min-content, size * 4)" to "calc-size(calc-size(min-content, size + 20px), 2 * size)":
FAIL(Chrome:FAIL, Safari:FAIL) - value at progress 0.75 in animation of "width" from "calc-size(fit-content, 20px)" to "calc-size(calc-size(fit-content, 40px), size)":
FAIL(Chrome:PASS, Safari:FAIL) - value at progress 0.75 in animation of "width" from "calc-size(any, 20px)" to "calc-size(calc-size(fit-content, 40px), size)":
FAIL(Chrome:PASS, Safari:FAIL) - value at progress 0.75 in animation of "width" from "calc-size(calc-size(any, 30px), 20px)" to "calc-size(calc-size(fit-content, 40px), size)":
FAIL(Chrome:PASS, Safari:FAIL) - value at progress 0.75 in animation of "width" from "calc-size(fit-content, 20px)" to "calc-size(calc-size(fit-content, 3 * size + 10px), min(size + 20px, 2 * size - 30px) + ((2 * size) + 80px))":
FAIL(Chrome:FAIL, Safari:FAIL) - value at progress 0.75 in animation of "width" from "calc-size(50%, size)" to "calc-size(calc-size(45%, (2 * size)), size + 20px)":
FAIL(Chrome:FAIL, Safari:FAIL) - value at progress 0.75 in animation of "width" from "calc-size(40%, size)" to "calc-size(calc-size(10px, (2 * size)), size + 20px)":
FAIL(Chrome:FAIL, Safari:FAIL) - value at progress 0.75 in animation of "width" from "calc-size(80px, size)" to "calc-size(calc-size(10px, (2 * size)), size + 20px)":
FAIL(Chrome:PASS, Safari:FAIL) - value at progress 0.75 in animation of "width" from "calc-size(80px, size)" to "calc-size(calc-size(any, 20px), size + 20px)":
FAIL(Chrome:PASS, Safari:FAIL)
- value at progress 0.75 in animation of "height" from "auto" to "calc-size(any, 0px)":
|
||
Comment 5•21 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0d2363e17702
https://hg.mozilla.org/mozilla-central/rev/80745eb946c7
Description
•